-
Notifications
You must be signed in to change notification settings - Fork 536
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mark build output "sideEffects": false (#23501)
## Description During the build we copy package.json files into the output for CJS builds and some ESM builds. Thes files lacked `"sideEffects": false` resulting in poor tree shaking for any bundle using build output with a copied package.json. This included the tree package ESM build which caused its bundle to bloat. This package.json copy has been removed from the tree package's esm build, but also update to include `"sideEffects": false` for builds that use it.
- Loading branch information
1 parent
ddce270
commit 62836c0
Showing
3 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"type": "commonjs" | ||
"type": "commonjs", | ||
"sideEffects": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"type": "module" | ||
"type": "module", | ||
"sideEffects": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters