From 08aef9c9274bdcd37a68c051e23e0c3b1ea89fa0 Mon Sep 17 00:00:00 2001 From: Sonali Deshpande <48232592+sonalideshpandemsft@users.noreply.github.com> Date: Wed, 15 Jan 2025 13:50:38 -0800 Subject: [PATCH] Revert "target es2021 (#23307)" (#23567) Reverting this commit as it causes the integration pipeline to fail. [ADO](https://dev.azure.com/fluidframework/internal/_workitems/edit/28536) --- .changeset/ripe-taxes-press.md | 16 ---------------- common/build/build-common/tsconfig.base.json | 2 +- .../driver-definitions.legacy.alpha.api.md | 2 +- 3 files changed, 2 insertions(+), 18 deletions(-) delete mode 100644 .changeset/ripe-taxes-press.md diff --git a/.changeset/ripe-taxes-press.md b/.changeset/ripe-taxes-press.md deleted file mode 100644 index 58f6e0ecf12f..000000000000 --- a/.changeset/ripe-taxes-press.md +++ /dev/null @@ -1,16 +0,0 @@ ---- ---- ---- -"section": other ---- - -Target ES2021 - -The TypeScript build for Fluid Framework packages has been updated to target ES2021 instead of ES2020. -This may result in newer JavaScript language features being used. -This does not change TypeScript types, nor the JavaScript libraries being used. -We only support users which support ES2022, so updating to target ES2021 should not break any supported use-case. -Any users which do not have at least ES2021 language feature support may need to transpile out some additional cases after this change. - -This should result in slightly reduced bundle size and slightly improved performance for users not transpiling these features out. -No major impact is expected. diff --git a/common/build/build-common/tsconfig.base.json b/common/build/build-common/tsconfig.base.json index c252a63b1a15..9420d5c7d2c7 100644 --- a/common/build/build-common/tsconfig.base.json +++ b/common/build/build-common/tsconfig.base.json @@ -13,7 +13,7 @@ "pretty": true, "sourceMap": true, "strict": true, - "target": "ES2021", + "target": "ES2020", "types": [], // Enabling these compiler flags is necessary for typechecking compliance with semver as per https://www.semver-ts.org/ // See specifically https://www.semver-ts.org/formal-spec/5-compiler-considerations.html#strictness. diff --git a/packages/common/driver-definitions/api-report/driver-definitions.legacy.alpha.api.md b/packages/common/driver-definitions/api-report/driver-definitions.legacy.alpha.api.md index 7d8a99a691de..1ad7ec6861b9 100644 --- a/packages/common/driver-definitions/api-report/driver-definitions.legacy.alpha.api.md +++ b/packages/common/driver-definitions/api-report/driver-definitions.legacy.alpha.api.md @@ -70,7 +70,7 @@ export enum FileMode { } // @alpha (undocumented) -export type FiveDaysMs = 432_000_000; +export type FiveDaysMs = 432000000; // @alpha export interface IAnyDriverError extends Omit {