Control the kernel injection with new argument. And compare the outputs only on rank 0 #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foin6
requested review from
tjruwase,
ShadenSmith,
conglongli,
awan-10,
eltonzheng,
minjiaz,
duli2012,
mrwyattii,
arashb and
xiaoxiawu-microsoft
as code owners
|
Please take time to review the PR. Thanks! |
|
@tjruwase Please take time to review the PR. Thanks! |
tjruwase
requested review from
lekurile
and removed request for
arashb,
ShadenSmith,
duli2012,
conglongli,
awan-10,
mrwyattii,
eltonzheng,
minjiaz and
xiaoxiawu-microsoft
|
@tjruwase Hi! Is there any problem with this PR? If so, we can talk to solve this, if not, please take time to move forward. Thanks a lot! |
lekurile
reviewed
Jan 29, 2024
lekurile
reviewed
Jan 29, 2024
lekurile
reviewed
Jan 29, 2024
|
Hi, @tjruwase ! Sorry for bothering, but it has been 2 days since my newest submission, please take time to move forward. It's important to me. Appreciate! |
lekurile
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting "--use_kernel" as "False" to disable kernel injection when running on CPUs;
The original code will infer the baseline on the same pipeline for several times when enabling multiple accelerators. But actually, there only needs to calculate once on rank 0 and compare with ds results.