From ce22731536322a723610de18025e32a75f6b4536 Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Mon, 6 Apr 2020 13:54:01 -0700 Subject: [PATCH 1/3] Remove Microsoft.AspNetCore.Hosting eventcounters by default (#1763) --- CHANGELOG.md | 3 +++ .../Extensions/ApplicationInsightsExtensions.cs | 3 +-- .../Extensions/ApplicationInsightsExtensionsTests.cs | 10 ++-------- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 80766a319e..a2b0e24138 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## VNext +## Version 2.14.0-beta5 +- [Stop collecting EventCounters from Microsoft.AspNetCore.Hosting](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1759) + ## Version 2.14.0-beta4 - [Fix: SQL dependency names are bloated when running under the .NET Framework and using Microsoft.Data.SqlClient package](https://github.com/microsoft/ApplicationInsights-dotnet/pull/1723) - [Fix: Disabling HeartBeats in Asp.Net Core projects causes Error traces every heart beat interval (15 minutes defualt)](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1681) diff --git a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs index 0d98837bd6..d076685c57 100644 --- a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs +++ b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs @@ -134,8 +134,7 @@ public static IServiceCollection AddApplicationInsightsTelemetry(this IServiceCo AddTelemetryChannel(services); #if NETSTANDARD2_0 - ConfigureEventCounterModuleWithSystemCounters(services); - ConfigureEventCounterModuleWithAspNetCounters(services); + ConfigureEventCounterModuleWithSystemCounters(services); #endif services.TryAddSingleton, diff --git a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs index 3332d28403..b13cdd20ef 100644 --- a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs +++ b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs @@ -632,19 +632,13 @@ public static void RegistersTelemetryConfigurationFactoryMethodThatPopulatesEven var eventCounterModule = modules.OfType().Single(); //VALIDATE - Assert.Equal(23, eventCounterModule.Counters.Count); + Assert.Equal(19, eventCounterModule.Counters.Count); // sanity check with a sample counter. var cpuCounterRequest = eventCounterModule.Counters.FirstOrDefault( eventCounterCollectionRequest => eventCounterCollectionRequest.EventSourceName == "System.Runtime" && eventCounterCollectionRequest.EventCounterName == "cpu-usage"); - Assert.NotNull(cpuCounterRequest); - - // sanity check - asp.net counters should be added - var aspnetCounterRequest = eventCounterModule.Counters.Where( - eventCounterCollectionRequest => eventCounterCollectionRequest.EventSourceName == "Microsoft.AspNetCore.Hosting"); - Assert.NotNull(aspnetCounterRequest); - Assert.True(aspnetCounterRequest.Count() == 4); + Assert.NotNull(cpuCounterRequest); } #endif From 4d933aac021ece55787309707d9090940f384c0d Mon Sep 17 00:00:00 2001 From: Eddy Nakamura Date: Mon, 6 Apr 2020 19:31:47 -0300 Subject: [PATCH 2/3] Adding support to net461 to ILogger (#1539) * adding support to net461 to ILogger * adding NET461 to the same conditions as NET46 * reverting ilogger and adding net461 to test project * re-adding net461 to applicationInsights.AspNetCore project * updating changelog to include net461 to vnext for ApplicationInsights.AspNetCore; updating ApplicationInsights.AspNetCore.Tests.csproj to include conditions to net461; adding publicAPI.Shipped for net461 for ApplicationInsights.AspNetCore * updating publicapi; adding net461 in missing files * updating condition and comment * updating tests to NET461 * adding net461 to loggerTests * Update CHANGELOG.md --- .../net461/PublicAPI.Shipped.txt | 153 ++++++++++++++++++ .../net461/PublicAPI.Unshipped.txt | 1 + CHANGELOG.md | 1 + .../ApplicationInsightsExtensions.cs | 2 +- .../Extensions/RequestCollectionOptions.cs | 2 +- .../ApplicationInsightsLogger.cs | 2 +- .../ApplicationInsightsLoggerProvider.cs | 4 +- ...soft.ApplicationInsights.AspNetCore.csproj | 6 +- .../SdkVersionUtils.cs | 2 +- .../ApplicationInsightsExtensions.cs | 2 +- ...ainNameRoleInstanceTelemetryInitializer.cs | 2 +- .../ApplicationInsightsExtensionsTests.cs | 2 +- ...pplicationInsights.AspNetCore.Tests.csproj | 13 +- .../SdkVersionTestUtils.cs | 2 +- ...meRoleInstanceTelemetryInitializerTests.cs | 2 +- .../FunctionalTest/LoggerTests.cs | 6 +- 16 files changed, 179 insertions(+), 23 deletions(-) create mode 100644 .publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Shipped.txt create mode 100644 .publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Unshipped.txt diff --git a/.publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Shipped.txt b/.publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Shipped.txt new file mode 100644 index 0000000000..e35a51d78a --- /dev/null +++ b/.publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Shipped.txt @@ -0,0 +1,153 @@ +abstract Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.TelemetryInitializerBase.OnInitializeTelemetry(Microsoft.AspNetCore.Http.HttpContext platformContext, Microsoft.ApplicationInsights.DataContracts.RequestTelemetry requestTelemetry, Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.Dispose() -> void +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.ListenerName.get -> string +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.MvcDiagnosticsListener() -> void +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.OnBeforeAction(Microsoft.AspNetCore.Http.HttpContext httpContext, System.Collections.Generic.IDictionary routeValues) -> void +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.OnCompleted() -> void +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.OnError(System.Exception error) -> void +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.OnNext(System.Collections.Generic.KeyValuePair value) -> void +Microsoft.ApplicationInsights.AspNetCore.DiagnosticListeners.MvcDiagnosticsListener.OnSubscribe() -> void +Microsoft.ApplicationInsights.AspNetCore.ExceptionTrackingMiddleware +Microsoft.ApplicationInsights.AspNetCore.ExceptionTrackingMiddleware.ExceptionTrackingMiddleware(Microsoft.AspNetCore.Http.RequestDelegate next, Microsoft.ApplicationInsights.TelemetryClient client) -> void +Microsoft.ApplicationInsights.AspNetCore.ExceptionTrackingMiddleware.Invoke(Microsoft.AspNetCore.Http.HttpContext httpContext) -> System.Threading.Tasks.Task +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.AddAutoCollectedMetricExtractor.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.AddAutoCollectedMetricExtractor.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.ApplicationInsightsServiceOptions() -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.ApplicationVersion.get -> string +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.ApplicationVersion.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.ConnectionString.get -> string +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.ConnectionString.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.DependencyCollectionOptions.get -> Microsoft.ApplicationInsights.AspNetCore.Extensions.DependencyCollectionOptions +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.DeveloperMode.get -> bool? +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.DeveloperMode.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAdaptiveSampling.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAdaptiveSampling.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAppServicesHeartbeatTelemetryModule.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAppServicesHeartbeatTelemetryModule.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAuthenticationTrackingJavaScript.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAuthenticationTrackingJavaScript.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAzureInstanceMetadataTelemetryModule.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableAzureInstanceMetadataTelemetryModule.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableDebugLogger.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableDebugLogger.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableDependencyTrackingTelemetryModule.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableDependencyTrackingTelemetryModule.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableHeartbeat.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableHeartbeat.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnablePerformanceCounterCollectionModule.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnablePerformanceCounterCollectionModule.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableQuickPulseMetricStream.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableQuickPulseMetricStream.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableRequestTrackingTelemetryModule.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EnableRequestTrackingTelemetryModule.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EndpointAddress.get -> string +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.EndpointAddress.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.InstrumentationKey.get -> string +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.InstrumentationKey.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions.RequestCollectionOptions.get -> Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions +Microsoft.ApplicationInsights.AspNetCore.Extensions.DependencyCollectionOptions +Microsoft.ApplicationInsights.AspNetCore.Extensions.DependencyCollectionOptions.DependencyCollectionOptions() -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.DependencyCollectionOptions.EnableLegacyCorrelationHeadersInjection.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.DependencyCollectionOptions.EnableLegacyCorrelationHeadersInjection.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.HttpRequestExtensions +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions.EnableW3CDistributedTracing.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions.EnableW3CDistributedTracing.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions.InjectResponseHeaders.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions.InjectResponseHeaders.set -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions.RequestCollectionOptions() -> void +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions.TrackExceptions.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions.TrackExceptions.set -> void +Microsoft.ApplicationInsights.AspNetCore.IJavaScriptSnippet +Microsoft.ApplicationInsights.AspNetCore.IJavaScriptSnippet.FullScript.get -> string +Microsoft.ApplicationInsights.AspNetCore.ITelemetryModuleConfigurator +Microsoft.ApplicationInsights.AspNetCore.ITelemetryModuleConfigurator.Configure(Microsoft.ApplicationInsights.Extensibility.ITelemetryModule telemetryModule) -> void +Microsoft.ApplicationInsights.AspNetCore.ITelemetryModuleConfigurator.Configure(Microsoft.ApplicationInsights.Extensibility.ITelemetryModule telemetryModule, Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions options) -> void +Microsoft.ApplicationInsights.AspNetCore.ITelemetryModuleConfigurator.TelemetryModuleType.get -> System.Type +Microsoft.ApplicationInsights.AspNetCore.ITelemetryProcessorFactory +Microsoft.ApplicationInsights.AspNetCore.ITelemetryProcessorFactory.Create(Microsoft.ApplicationInsights.Extensibility.ITelemetryProcessor nextProcessor) -> Microsoft.ApplicationInsights.Extensibility.ITelemetryProcessor +Microsoft.ApplicationInsights.AspNetCore.JavaScriptSnippet +Microsoft.ApplicationInsights.AspNetCore.JavaScriptSnippet.FullScript.get -> string +Microsoft.ApplicationInsights.AspNetCore.JavaScriptSnippet.JavaScriptSnippet(Microsoft.ApplicationInsights.Extensibility.TelemetryConfiguration telemetryConfiguration, Microsoft.Extensions.Options.IOptions serviceOptions, Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor, System.Text.Encodings.Web.JavaScriptEncoder encoder = null) -> void +Microsoft.ApplicationInsights.AspNetCore.Logging.ApplicationInsightsLoggerOptions +Microsoft.ApplicationInsights.AspNetCore.Logging.ApplicationInsightsLoggerOptions.ApplicationInsightsLoggerOptions() -> void +Microsoft.ApplicationInsights.AspNetCore.Logging.ApplicationInsightsLoggerOptions.IncludeEventId.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Logging.ApplicationInsightsLoggerOptions.IncludeEventId.set -> void +Microsoft.ApplicationInsights.AspNetCore.Logging.ApplicationInsightsLoggerOptions.TrackExceptionsAsExceptionTelemetry.get -> bool +Microsoft.ApplicationInsights.AspNetCore.Logging.ApplicationInsightsLoggerOptions.TrackExceptionsAsExceptionTelemetry.set -> void +Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule +Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule.CollectionOptions.get -> Microsoft.ApplicationInsights.AspNetCore.Extensions.RequestCollectionOptions +Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule.CollectionOptions.set -> void +Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule.Dispose() -> void +Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule.Initialize(Microsoft.ApplicationInsights.Extensibility.TelemetryConfiguration configuration) -> void +Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule.RequestTrackingTelemetryModule() -> void +Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule.RequestTrackingTelemetryModule(Microsoft.ApplicationInsights.Extensibility.IApplicationIdProvider applicationIdProvider) -> void +Microsoft.ApplicationInsights.AspNetCore.Resources +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AspNetCoreEnvironmentTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AspNetCoreEnvironmentTelemetryInitializer.AspNetCoreEnvironmentTelemetryInitializer(Microsoft.AspNetCore.Hosting.IHostingEnvironment environment) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AspNetCoreEnvironmentTelemetryInitializer.Initialize(Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AzureAppServiceRoleNameFromHostNameHeaderInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AzureAppServiceRoleNameFromHostNameHeaderInitializer.AzureAppServiceRoleNameFromHostNameHeaderInitializer(string webAppSuffix = ".azurewebsites.net") -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AzureAppServiceRoleNameFromHostNameHeaderInitializer.Initialize(Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AzureAppServiceRoleNameFromHostNameHeaderInitializer.WebAppSuffix.get -> string +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.AzureAppServiceRoleNameFromHostNameHeaderInitializer.WebAppSuffix.set -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer.ClientIpHeaderTelemetryInitializer(Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer.HeaderNames.get -> System.Collections.Generic.ICollection +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer.HeaderValueSeparators.get -> string +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer.HeaderValueSeparators.set -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer.UseFirstIp.get -> bool +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer.UseFirstIp.set -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ComponentVersionTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ComponentVersionTelemetryInitializer.ComponentVersionTelemetryInitializer(Microsoft.Extensions.Options.IOptions options) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ComponentVersionTelemetryInitializer.Initialize(Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.DomainNameRoleInstanceTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.DomainNameRoleInstanceTelemetryInitializer.DomainNameRoleInstanceTelemetryInitializer() -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.DomainNameRoleInstanceTelemetryInitializer.Initialize(Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.OperationNameTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.OperationNameTelemetryInitializer.OperationNameTelemetryInitializer(Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.SyntheticTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.SyntheticTelemetryInitializer.SyntheticTelemetryInitializer(Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.TelemetryInitializerBase +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.TelemetryInitializerBase.Initialize(Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.TelemetryInitializerBase.TelemetryInitializerBase(Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.WebSessionTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.WebSessionTelemetryInitializer.WebSessionTelemetryInitializer(Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor) -> void +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.WebUserTelemetryInitializer +Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.WebUserTelemetryInitializer.WebUserTelemetryInitializer(Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor) -> void +Microsoft.AspNetCore.Hosting.ApplicationInsightsWebHostBuilderExtensions +Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions +Microsoft.Extensions.Logging.ApplicationInsightsLoggerFactoryExtensions +override Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.ClientIpHeaderTelemetryInitializer.OnInitializeTelemetry(Microsoft.AspNetCore.Http.HttpContext platformContext, Microsoft.ApplicationInsights.DataContracts.RequestTelemetry requestTelemetry, Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +override Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.OperationNameTelemetryInitializer.OnInitializeTelemetry(Microsoft.AspNetCore.Http.HttpContext platformContext, Microsoft.ApplicationInsights.DataContracts.RequestTelemetry requestTelemetry, Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +override Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.SyntheticTelemetryInitializer.OnInitializeTelemetry(Microsoft.AspNetCore.Http.HttpContext platformContext, Microsoft.ApplicationInsights.DataContracts.RequestTelemetry requestTelemetry, Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +override Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.WebSessionTelemetryInitializer.OnInitializeTelemetry(Microsoft.AspNetCore.Http.HttpContext platformContext, Microsoft.ApplicationInsights.DataContracts.RequestTelemetry requestTelemetry, Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +override Microsoft.ApplicationInsights.AspNetCore.TelemetryInitializers.WebUserTelemetryInitializer.OnInitializeTelemetry(Microsoft.AspNetCore.Http.HttpContext platformContext, Microsoft.ApplicationInsights.DataContracts.RequestTelemetry requestTelemetry, Microsoft.ApplicationInsights.Channel.ITelemetry telemetry) -> void +static Microsoft.ApplicationInsights.AspNetCore.Extensions.HttpRequestExtensions.GetUri(this Microsoft.AspNetCore.Http.HttpRequest request) -> System.Uri +static Microsoft.ApplicationInsights.AspNetCore.Resources.Culture.get -> System.Globalization.CultureInfo +static Microsoft.ApplicationInsights.AspNetCore.Resources.Culture.set -> void +static Microsoft.ApplicationInsights.AspNetCore.Resources.JavaScriptAuthSnippet.get -> string +static Microsoft.ApplicationInsights.AspNetCore.Resources.JavaScriptSnippet.get -> string +static Microsoft.ApplicationInsights.AspNetCore.Resources.ResourceManager.get -> System.Resources.ResourceManager +static Microsoft.AspNetCore.Hosting.ApplicationInsightsWebHostBuilderExtensions.UseApplicationInsights(this Microsoft.AspNetCore.Hosting.IWebHostBuilder webHostBuilder) -> Microsoft.AspNetCore.Hosting.IWebHostBuilder +static Microsoft.AspNetCore.Hosting.ApplicationInsightsWebHostBuilderExtensions.UseApplicationInsights(this Microsoft.AspNetCore.Hosting.IWebHostBuilder webHostBuilder, string instrumentationKey) -> Microsoft.AspNetCore.Hosting.IWebHostBuilder +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsSettings(this Microsoft.Extensions.Configuration.IConfigurationBuilder configurationSourceRoot, bool? developerMode = null, string endpointAddress = null, string instrumentationKey = null) -> Microsoft.Extensions.Configuration.IConfigurationBuilder +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsSettings(this Microsoft.Extensions.Configuration.IConfigurationBuilder configurationSourceRoot, string connectionString, bool? developerMode = null, string endpointAddress = null, string instrumentationKey = null) -> Microsoft.Extensions.Configuration.IConfigurationBuilder +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetry(this Microsoft.Extensions.DependencyInjection.IServiceCollection services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetry(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, Microsoft.ApplicationInsights.AspNetCore.Extensions.ApplicationInsightsServiceOptions options) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetry(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, Microsoft.Extensions.Configuration.IConfiguration configuration) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetry(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, string instrumentationKey) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetry(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Action options) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetryProcessor(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Type telemetryProcessorType) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.AddApplicationInsightsTelemetryProcessor(this Microsoft.Extensions.DependencyInjection.IServiceCollection services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.ConfigureTelemetryModule(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Action configModule) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.ConfigureTelemetryModule(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Action configModule) -> Microsoft.Extensions.DependencyInjection.IServiceCollection +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.UseApplicationInsightsExceptionTelemetry(this Microsoft.AspNetCore.Builder.IApplicationBuilder app) -> Microsoft.AspNetCore.Builder.IApplicationBuilder +static Microsoft.Extensions.DependencyInjection.ApplicationInsightsExtensions.UseApplicationInsightsRequestTelemetry(this Microsoft.AspNetCore.Builder.IApplicationBuilder app) -> Microsoft.AspNetCore.Builder.IApplicationBuilder +static Microsoft.Extensions.Logging.ApplicationInsightsLoggerFactoryExtensions.AddApplicationInsights(this Microsoft.Extensions.Logging.ILoggerFactory factory, System.IServiceProvider serviceProvider) -> Microsoft.Extensions.Logging.ILoggerFactory +static Microsoft.Extensions.Logging.ApplicationInsightsLoggerFactoryExtensions.AddApplicationInsights(this Microsoft.Extensions.Logging.ILoggerFactory factory, System.IServiceProvider serviceProvider, Microsoft.Extensions.Logging.LogLevel minLevel) -> Microsoft.Extensions.Logging.ILoggerFactory +static Microsoft.Extensions.Logging.ApplicationInsightsLoggerFactoryExtensions.AddApplicationInsights(this Microsoft.Extensions.Logging.ILoggerFactory factory, System.IServiceProvider serviceProvider, System.Func filter) -> Microsoft.Extensions.Logging.ILoggerFactory +static Microsoft.Extensions.Logging.ApplicationInsightsLoggerFactoryExtensions.AddApplicationInsights(this Microsoft.Extensions.Logging.ILoggerFactory factory, System.IServiceProvider serviceProvider, System.Func filter, System.Action loggerAddedCallback) -> Microsoft.Extensions.Logging.ILoggerFactory +virtual Microsoft.ApplicationInsights.AspNetCore.RequestTrackingTelemetryModule.Dispose(bool disposing) -> void diff --git a/.publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Unshipped.txt b/.publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Unshipped.txt new file mode 100644 index 0000000000..d85d39b736 --- /dev/null +++ b/.publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/net461/PublicAPI.Unshipped.txt @@ -0,0 +1 @@ +Microsoft.ApplicationInsights.AspNetCore.JavaScriptSnippet.ScriptBody.get -> string \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index a2b0e24138..227047ce91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ ## Version 2.14.0-beta5 - [Stop collecting EventCounters from Microsoft.AspNetCore.Hosting](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1759) +- [Enable ILogger provider for apps targetting .NET Framework](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1312) ## Version 2.14.0-beta4 - [Fix: SQL dependency names are bloated when running under the .NET Framework and using Microsoft.Data.SqlClient package](https://github.com/microsoft/ApplicationInsights-dotnet/pull/1723) diff --git a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs index d076685c57..58088449f7 100644 --- a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs +++ b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs @@ -154,7 +154,7 @@ public static IServiceCollection AddApplicationInsightsTelemetry(this IServiceCo // NetStandard2.0 has a package reference to Microsoft.Extensions.Logging.ApplicationInsights, and // enables ApplicationInsightsLoggerProvider by default. -#if NETSTANDARD2_0 +#if NETSTANDARD2_0 || NET461 AddApplicationInsightsLoggerProvider(services); #endif } diff --git a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/RequestCollectionOptions.cs b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/RequestCollectionOptions.cs index 1eed1d6d06..306dea33b8 100644 --- a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/RequestCollectionOptions.cs +++ b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/RequestCollectionOptions.cs @@ -17,7 +17,7 @@ public RequestCollectionOptions() // In NetStandard20, ApplicationInsightsLoggerProvider is enabled by default, // which captures Exceptions. Disabling it in RequestCollectionModule to avoid duplication. -#if NETSTANDARD2_0 +#if NETSTANDARD2_0 || NET461 this.TrackExceptions = false; #else this.TrackExceptions = true; diff --git a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLogger.cs b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLogger.cs index e6e5d46db9..8e100ab7f3 100644 --- a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLogger.cs +++ b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLogger.cs @@ -19,7 +19,7 @@ [SuppressMessage("Documentation Rules", "SA1614:ElementParameterDocumentationMustHaveText", Justification = "This class is obsolete and will not be completely documented.")] internal class ApplicationInsightsLogger : ILogger { -#if NET451 || NET46 +#if NET451 || NET46 || NET461 /// /// SDK Version Prefix. /// diff --git a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLoggerProvider.cs b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLoggerProvider.cs index b120773caf..9885a2a103 100644 --- a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLoggerProvider.cs +++ b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLoggerProvider.cs @@ -9,8 +9,8 @@ /// /// implementation that creates returns instances of . /// -#if !NETSTANDARD2_0 - // For NETSTANDARD2.0 We take dependency on Microsoft.Extensions.Logging.ApplicationInsights which has ApplicationInsightsProvider having the same ProviderAlias and don't want to clash with this ProviderAlias. +#if !NETSTANDARD2_0 && !NET461 + // For NETSTANDARD2.0 and NET461 We take dependency on Microsoft.Extensions.Logging.ApplicationInsights which has ApplicationInsightsProvider having the same ProviderAlias and don't want to clash with this ProviderAlias. [ProviderAlias("ApplicationInsights")] #endif [SuppressMessage("Documentation Rules", "SA1614:ElementParameterDocumentationMustHaveText", Justification = "This class is obsolete and will not be completely documented.")] diff --git a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj index 218d5334a9..a4dee2d74a 100644 --- a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj +++ b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj @@ -15,7 +15,7 @@ Microsoft.ApplicationInsights.AspNetCore 7.2 - netstandard2.0;net451;net46;netstandard1.6 + netstandard2.0;net451;net46;net461;netstandard1.6 netstandard1.6;netstandard2.0 1.6.1 @@ -72,12 +72,12 @@ - + - + diff --git a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/SdkVersionUtils.cs b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/SdkVersionUtils.cs index 02bf47ce30..0a0137af1c 100644 --- a/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/SdkVersionUtils.cs +++ b/NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/SdkVersionUtils.cs @@ -8,7 +8,7 @@ /// internal class SdkVersionUtils { -#if NET451 || NET46 +#if NET451 || NET46 || NET461 /// /// SDK Version Prefix. /// diff --git a/NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs b/NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs index 585cfffcce..997afe311b 100644 --- a/NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs +++ b/NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs @@ -446,7 +446,7 @@ private static void ConfigureEventCounterModuleWithAspNetCounters(IServiceCollec [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", Justification = "services parameter is used in only NetStandard 2.0 build.")] private static void AddApplicationInsightsLoggerProvider(IServiceCollection services) { -#if NETSTANDARD2_0 +#if NETSTANDARD2_0 || NET461 services.AddLogging(loggingBuilder => { loggingBuilder.AddApplicationInsights(); diff --git a/NETCORE/src/Shared/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializer.cs b/NETCORE/src/Shared/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializer.cs index de13c505df..e3ba5420fa 100644 --- a/NETCORE/src/Shared/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializer.cs +++ b/NETCORE/src/Shared/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializer.cs @@ -43,7 +43,7 @@ private string GetMachineName() string hostName = Dns.GetHostName(); // Issue #61: For dnxcore machine name does not have domain name like in full framework -#if NET451 || NET46 +#if NET451 || NET46 || NET461 string domainName = IPGlobalProperties.GetIPGlobalProperties().DomainName; if (!hostName.EndsWith(domainName, StringComparison.OrdinalIgnoreCase)) { diff --git a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs index b13cdd20ef..9499fd40c6 100644 --- a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs +++ b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Extensions/ApplicationInsightsExtensionsTests.cs @@ -983,7 +983,7 @@ public static void ConfigureRequestTrackingTelemetryDefaultOptions() == typeof(RequestTrackingTelemetryModule)); Assert.True(requestTrackingModule.CollectionOptions.InjectResponseHeaders); -#if NETCOREAPP2_0 +#if NETCOREAPP2_0 || NET461 Assert.False(requestTrackingModule.CollectionOptions.TrackExceptions); #else Assert.True(requestTrackingModule.CollectionOptions.TrackExceptions); diff --git a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Microsoft.ApplicationInsights.AspNetCore.Tests.csproj b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Microsoft.ApplicationInsights.AspNetCore.Tests.csproj index a2b86ce3ab..c6065ab442 100644 --- a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Microsoft.ApplicationInsights.AspNetCore.Tests.csproj +++ b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/Microsoft.ApplicationInsights.AspNetCore.Tests.csproj @@ -4,8 +4,9 @@ 2.0.0 - netcoreapp2.0;net46 - netcoreapp2.0 + netcoreapp2.0;net46;net461 + netcoreapp2.0 + true true Microsoft.ApplicationInsights.AspNetCore.Tests Microsoft.ApplicationInsights.AspNetCore.Tests @@ -25,25 +26,25 @@ - + - + - + - + diff --git a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/SdkVersionTestUtils.cs b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/SdkVersionTestUtils.cs index 5c4ef4530a..b9f932b42a 100644 --- a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/SdkVersionTestUtils.cs +++ b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/SdkVersionTestUtils.cs @@ -2,7 +2,7 @@ { public class SdkVersionTestUtils { -#if NET451 || NET46 +#if NET451 || NET46 || NET461 public const string VersionPrefix = "aspnet5f:"; #else public const string VersionPrefix = "aspnet5c:"; diff --git a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializerTests.cs b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializerTests.cs index 67e7c297c5..bfd22cc6d5 100644 --- a/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializerTests.cs +++ b/NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/TelemetryInitializers/DomainNameRoleInstanceTelemetryInitializerTests.cs @@ -24,7 +24,7 @@ public void RoleInstanceNameIsSetToDomainAndHost() string hostName = Dns.GetHostName(); -#if NET46 +#if NET46 || NET461 string domainName = IPGlobalProperties.GetIPGlobalProperties().DomainName; if (hostName.EndsWith(domainName, StringComparison.OrdinalIgnoreCase) == false) { diff --git a/NETCORE/test/WebApi20.FunctionalTests/FunctionalTest/LoggerTests.cs b/NETCORE/test/WebApi20.FunctionalTests/FunctionalTest/LoggerTests.cs index 9a363c220e..84397ed272 100644 --- a/NETCORE/test/WebApi20.FunctionalTests/FunctionalTest/LoggerTests.cs +++ b/NETCORE/test/WebApi20.FunctionalTests/FunctionalTest/LoggerTests.cs @@ -36,7 +36,7 @@ public LoggerTests(ITestOutputHelper output) : base (output) public void TestIloggerWarningOrAboveIsCapturedByDefault() { -#if NETCOREAPP2_0 +#if NETCOREAPP2_0 || NET461 using (var server = new InProcessServer(assemblyName, this.output)) { // Make request to this path, which sents one log of each severity Error, Warning, Information, Trace @@ -59,7 +59,7 @@ public void TestIloggerWarningOrAboveIsCapturedByDefault() public void TestIloggerDefaultsCanBeOverridenByUserForAllCategories() { -#if NETCOREAPP2_0 +#if NETCOREAPP2_0 || NET461 void ConfigureServices(IServiceCollection services) { // ARRANGE @@ -88,7 +88,7 @@ void ConfigureServices(IServiceCollection services) public void TestIloggerDefaultsCanBeOverridenByUserForSpecificCategory() { -#if NETCOREAPP2_0 +#if NETCOREAPP2_0 || NET461 void ConfigureServices(IServiceCollection services) { // ARRANGE From 66b38d506b3bfde0ca65a39e8159cd2cb1b3f922 Mon Sep 17 00:00:00 2001 From: Timothy Mothra Date: Mon, 6 Apr 2020 16:08:27 -0700 Subject: [PATCH 3/3] bump version 2.14-beta5 (#1765) --- .props/_GlobalStaticVersion.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.props/_GlobalStaticVersion.props b/.props/_GlobalStaticVersion.props index b41d63c8b4..5b667e7aef 100644 --- a/.props/_GlobalStaticVersion.props +++ b/.props/_GlobalStaticVersion.props @@ -13,7 +13,7 @@ 2 14 0 - beta4 + beta5