Skip to content

play-services-auth-workaccount: Remove maxSdkVersion from perms #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

play-services-auth-workaccount: Remove maxSdkVersion from perms #2882

wants to merge 1 commit into from

Conversation

chirayudesai
Copy link
Contributor

  • This is causing them not to be granted at all on newer devices, potentially leading to issues.
  • They're already declared in play-services-core as well.

Bug: #2868

@chirayudesai
play-services-auth-workaccount: Remove maxSdkVersion from perms
d455143 
* This is causing them not to be granted at all on newer devices,
  _potentially_ leading to issues.
* They're already declared in play-services-core as well.

Bug: microg#2868
Change-Id: I37c1cb2c19006a0373bac6e6d097a2cf39c73117
@chirayudesai
Copy link
Contributor Author

See #2868 (comment) for more.

Could also remove them from -auth-workaccount, if that's preferred.

We've got at least two reports so far of people having issues with Gmail and Calendar sync after 0.3.7 - and this felt related. Need to investigate further, but in the interim, this was an easy thing to do.

@ale5000-git ale5000-git linked an issue Apr 29, 2025 that may be closed by this pull request
I can't give the new permission to search device accounts #2868
Open
@mar-v-in mar-v-in added this to the 0.3.8 milestone May 6, 2025
@ale5000-git
Copy link
Member

@chirayudesai
We need to keep android.permission.GET_ACCOUNTS on all Android versions to be sure to have everything working but not android.permission.AUTHENTICATE_ACCOUNTS and android.permission.MANAGE_ACCOUNTS that are deprecated in new Android versions (they no longer do anything).

See:
https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-6.0.1_r81/core/res/AndroidManifest.xml#804
https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-6.0.1_r81/core/res/AndroidManifest.xml#809

So I suggest to remove maxSdkVersion only from android.permission.GET_ACCOUNTS and update self-check accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.8
Development

Successfully merging this pull request may close these issues.

I can't give the new permission to search device accounts
3 participants
@chirayudesai @ale5000-git @mar-v-in