Use nmdc-schema
-provided function to get typecode from slot pattern
#878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch, I changed how the minter gets typecodes from the schema.
Details
Previously, the minter would use a locally-defined function (named
extract_typecode_from_pattern
) to extract typecodes fromid
slot patterns. That ran the risk of falling out of sync with how the same thing is done in thenmdc-schema
package. On this branch, I deleted the locally-defined function and updated the calling code to call an equivalent function (namedget_typecode_for_future_ids
) provided by thenmdc-schema
package.Related issue(s)
Fixes #866
Related subsystem(s)
docs
directory)Testing
I tested these changes by implementing a basic doctest and running it locally via:
🙋 Question: Does the GHA test process run doctests?
Documentation
docs
directory)Maintainability
study_id: str
)# TODO
or# FIXME
black
to format all the Python files I created/modified