Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time referential integrity checking is broken #860

Closed
eecavanna opened this issue Jan 16, 2025 · 2 comments · Fixed by #861
Closed

Real-time referential integrity checking is broken #860

eecavanna opened this issue Jan 16, 2025 · 2 comments · Fixed by #861
Assignees
Labels
bug Something isn't working X SMALL Less than 1 day

Comments

@eecavanna
Copy link
Collaborator

eecavanna commented Jan 16, 2025

Real-time referential integrity checking was introduced into the validate_json function via PR #835 this week.

The implementation is broken.

In terms of behavior visible to end users:

  • It does not take into account data that already exists in the database (❗). As a result, it reports false positives.

In terms of the code:

  • The get_collection method that was added to the OverlayDB class only returns the so-called "top" database (it does not return a hybrid top+bottom database).
  • An OverlayDB instance is being passed to a function that was designed to receive an instance of pymongo's Database class.

CC: @aclum , @shreddd , @dwinston

@eecavanna eecavanna added bug Something isn't working X SMALL Less than 1 day labels Jan 16, 2025
@eecavanna eecavanna self-assigned this Jan 16, 2025
@eecavanna
Copy link
Collaborator Author

Given my workload for this week (launching the docs site), I propose this feature be reverted (from the main branch and, as a result, the development environment) until next week.

@aclum
Copy link
Contributor

aclum commented Jan 17, 2025

That is fine with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working X SMALL Less than 1 day
Projects
2 participants