test against more versions of Python in PR workflow #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtertiaer
force-pushed
the
test_against_more_python
branch
2 times, most recently
from
bdd0e48 to
42441d6
Compare
rtertiaer
force-pushed
the
test_against_more_python
branch
from
42441d6 to
39d513d
Compare
rtertiaer
commented
Dec 4, 2024
| - run: pip install -r requirements.txt | ||
| - run: pip install mypy | ||
| - run: mypy --install-types --non-interactive --explicit-package-bases --disable-error-code import-untyped . |
There was a problem hiding this comment.
--disable-error-code import-untyped isn't valid for earlier versions of mypy, which are in turn necessary to support python 3.7
rtertiaer
commented
Dec 4, 2024
| @@ -17,6 +17,6 @@ systemd-python | |||
| wireguard-tools | |||
| sqlmodel==0.0.19 | |||
| google-cloud-compute | |||
| cryptography==42.0.8 | |||
There was a problem hiding this comment.
addresses a CVE in <43.0.1
linknum23
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests against more version of Python in our GitHub Action. This mainly to guard against someone accidentally merging pyca/cryptography >=44, which deprecates Python 3.7 - yet we use 3.7 in our current AmpliPi product.