Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string_tree module in favor of deprecated string_builder module of Gleam #31

Merged
merged 12 commits into from
Nov 24, 2024

Conversation

diemogebhardt
Copy link
Contributor

@diemogebhardt diemogebhardt commented Nov 24, 2024

Since release 1.6.0 of Gleam, string_builder has been deprecated in favor of string_tree.

This PR:

Going through the individual commits should make it easier for you to review all changes in digestible chunks.

All tests are passing. Generated gleam code by a "from source" build of this branch has been deployed by a few projects to production already. :)

@michaeljones
Copy link
Owner

Thank you very much for this. Looks great. I appreciate the clear commit separation for the different aspects of the change.

It looks like our CI hasn't been run for a while and needs updating so I'll push some commits to try to do that but otherwise it looks great and I'd be happy merge and I'm grateful for your efforts!

As v2 has been deprecated for a while. This repo has been stable so
we haven't been running CI.
So that it doesn't end with 'Token' as clippy warns about variants
that end with the enum's name as a stylistic thing.

We could silence it but this is just as valid and works. Though
it requires regenerating tests.
We only have these to collect together errors for the stages of
the template processing and then Debug print them but rust doesn't
consider Debug printing to be a usage so it warns about them so we
have to disable the warning.
@michaeljones
Copy link
Owner

The further changes are presumably associated with newer versions of the rust toolchain and compiler warnings, etc.

We make the action version more general to get the latest and then
update the otp and gleam versions to be up to date.
Not sure why insta isn't removing this when run with
'--unreferenced delete' but it seems to be stale and the tests pass
without it.
@michaeljones michaeljones merged commit 337653f into michaeljones:main Nov 24, 2024
4 checks passed
@michaeljones
Copy link
Owner

You make a fair point about going 1.0. Let's see how this set of changes settles in and then we can go 1.0 (though I realise there is a risk I'll forget about it entirely!)

@diemogebhardt
Copy link
Contributor Author

Thank you very much for this. Looks great. I appreciate the clear commit separation for the different aspects of the change.

Oh, awesome – didn't expect for this to get merged that quick. Happy to contribute whenever I can. And thank you, for creating this in the first place! :)

You make a fair point about going 1.0. Let's see how this set of changes settles in and then we can go 1.0

Yeah, going 1.0.0 feels like a big step. I see it from the perspective of communicating the breaking changes of a dependency, less than a set of features. SemVer is great for that. When upgrading matcha from version 0.*.* to 0.*.* I would just yolo it without thinking. Seeing the version increase from 0.*.* to 1.*.* I would definitely check out the changelog first in order to decide whether I want to spend the next couple of hours refactoring my codebase.

Even though off-topic in the context of this PR: is there a specific set of features that you would like to see for 1.0.0?

(though I realise there is a risk I'll forget about it entirely!)

Let me create an issue (#32) as a reminder and you decide whatever to do with it... ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants