Merge pull request #30 from mgnsk/hotfix/reader-wg-race

Lock record during delete
mgnsk · Apr 12, 2021 · a1f2df4 · a1f2df4
2 parents 0f9df62 + e87b3ca
commit a1f2df4
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cache.go b/cache.go
@@ -409,6 +409,10 @@ func (c *Cache) deleteLocked(key interface{}, target *interface{}) (value interf
 	if r.State() != active {
 		return nil, false
 	}
+	// Safe to lock r.mu on an active record
+	// while holding c.mu.
+	r.mu.Lock()
+	defer r.mu.Unlock()
 	value = r.value
 	if target != nil && !reflect.DeepEqual(value, *target) {
 		return nil, false