variable to skip package name checks #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavacava
reviewed
Nov 26, 2023
rule/var-naming.go
Outdated
| Category: "naming", | ||
| }) | ||
| if !r.skipPackageNameChecks { | ||
| // Package names need slightly different handling than other names. |
There was a problem hiding this comment.
We could factor-out package checks into a method to get a simpler to read Apply method
|
HI @gburanov, thanks for the PR, I've left some comments in the code |
|
@gburanov Please also:
|
|
@chavacava I made the changes you suggested |
|
Thanks @gburanov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a pity that two functionalities are merged together in the rule
rule.var-naming- checking variable and package naming.In our company we find variable naming check very useful, but we do not want to check for packages naming.
Therefore I propose to add option to skip package name checks