Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better syntax error handling #332

Merged
merged 13 commits into from
Aug 30, 2024
Merged

Better syntax error handling #332

merged 13 commits into from
Aug 30, 2024

Conversation

jf-06
Copy link
Contributor

@jf-06 jf-06 commented Aug 30, 2024

Fixes #331
Also implements script logging.

jf-06 added 7 commits August 30, 2024 03:18
@jf-06
Debugging: Add tasks and launch
4496636 
~ Add build tasks for debug and full debug builds.
~ Add launch scripts for local debugging.
@jf-06
Projects: Bump Discord.Net
6be7c24 
Bumps Discord.Net to 3.15.3
@jf-06
Update to OnLogMessage
1965b35 
Support logging GatewayReconnectException, WebSocketException, WebSocketClosedException, and TaskCanceledException in debug builds
@jf-06
Feature: Script logging
8630fdd 
Implement logging of scripts to a Discord channel, helps with future debugging of issues that arrise.
Has duplication detection via hash checking of script contents.
@jf-06
LuaVM
724f2b8 
Suit changes made to parsing system
@jf-06
ExecuteScript: Syntax error and script logging
e1d0819 
~ Log scripts just before preprocessing.
~ Add detection of grid-server level syntax errors.
~ Add detection of invalid json return data.
~ Add detection of invalid ASCII return data.
@jf-06
Update Runner.cs
8685e9b 
#!components: grid-bot,grid-bot-recovery

~ Add script logger to dependency injection container.
@jf-06 jf-06 added kind: feature This issue integrates a single feature (or multiple disguised as one) kind: enhancement This issue integrates a modification to an existing product or system. priority: key deliverable The issue is high priority and normally has a very close target quarter. platform: linux This issue relates to Linux. opsec: love-all-environments SEC-04-LAE opsec: love-all-platforms SEC-04-LAP opsec: public-ops SEC-02-PUBOPS opsec: discord-gateway SEC-25-GATEWAY opsec: we-love-clean-code SEC-10-WLCC area: discord Issue relates to discord area: code-ops Issue relates to the issue of Code Ops area: dependencies Pull requests that update a dependency file labels Aug 30, 2024
@jf-06 jf-06 added this to the SEC-10-WLCC milestone Aug 30, 2024
@jf-06 jf-06 self-assigned this Aug 30, 2024
@jf-06 jf-06 linked an issue Aug 30, 2024 that may be closed by this pull request
Better syntax error handling #331
Closed
jf-06 added 2 commits August 30, 2024 03:28
@jf-06
Update build.yml
69ff328 
Signed-off-by: Nikita Petko <petko@vmminfra.net>
@jf-06
Update deploy.yml
6275892 
Signed-off-by: Nikita Petko <petko@vmminfra.net>
jf-06 added 3 commits August 30, 2024 03:41
@jf-06
ScriptLogger: Persistence
fd3190f 
~ Do not persist script hashes immediately, as this could cause a major influx of Vault writes.
@jf-06
Update deploy.yml
c87f1f2 
Signed-off-by: Nikita Petko <petko@vmminfra.net>
@jf-06
Update .component.yaml
34491d6 
Signed-off-by: Nikita Petko <petko@vmminfra.net>
@jf-06 jf-06 merged commit 037e618 into master Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jf-06 jf-06

Labels
area: code-ops Issue relates to the issue of Code Ops area: dependencies Pull requests that update a dependency file area: discord Issue relates to discord kind: enhancement This issue integrates a modification to an existing product or system. kind: feature This issue integrates a single feature (or multiple disguised as one) opsec: discord-gateway SEC-25-GATEWAY opsec: love-all-environments SEC-04-LAE opsec: love-all-platforms SEC-04-LAP opsec: public-ops SEC-02-PUBOPS opsec: we-love-clean-code SEC-10-WLCC platform: linux This issue relates to Linux. priority: key deliverable The issue is high priority and normally has a very close target quarter.
Projects
GRIDBOT
Status: Complete
Milestone
SEC-10-WLCC
Development

Successfully merging this pull request may close these issues.

Better syntax error handling
2 participants
@jf-06 @grid-bot-deployer