Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper management of environment #316

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Proper management of environment #316

merged 4 commits into from
Jun 17, 2024

Conversation

jf-06
Copy link
Contributor

@jf-06 jf-06 commented Jun 17, 2024

Fixes #315

jf-06 added 2 commits June 17, 2024 02:46
@jf-06
#315: Better environment management
c1b06bb 
grid-bot.nomad:
~ Rename meta variable to ENVIRONMENT so it gets resolved to NOMAD_META_ENVIRONMENT
~ Remove need to specify the environment variable.

EnvironmentProvider.cs:
~ Basic class that reads either the ENVIRONMENT environment variable or the NOMAD_META_ENVIRONMENT environment variable, or defaults to development.

SettingsProviderDefaults.cs:
~ Use EnvironmentProvider.

src/Program.cs:
~ Fix an issue with the Redis resolver where it was resolving the wrong environment (for staging builds that were using development builds it was using "development" as the environment instead of the configured environment)
@jf-06
Better versioning
f56fcd6 
~ Embed build information.
~ Print build metadata
~ Prevent the source revision in the informational version.
@jf-06 jf-06 linked an issue Jun 17, 2024 that may be closed by this pull request
Proper management of environment #315
Closed
@jf-06 jf-06 added this to the SEC-10-WLCC milestone Jun 17, 2024
@jf-06
Copy link
Contributor Author

jf-06 commented Jun 17, 2024

2 new errors:

[2024-06-17T02:07:58.3619Z][10.128.0.21][grid-bot-stage.service.consul][bot][ERROR] Could not obtain the initial Redis endpoints from the service resolver within 10 seconds

[2024-06-17T02:08:00.0481Z][10.128.0.21][grid-bot-stage.service.consul][bot][ERROR] Exception encountered while acquiring host information from DNS: System.Net.Sockets.SocketException (00000005, 0xFFFDFFFF): Name or service not known
   at System.Net.Dns.GetHostEntryOrAddressesCore(String hostName, Boolean justAddresses, AddressFamily addressFamily, Nullable`1 startingTimestamp)
   at System.Net.Dns.GetHostEntry(String hostNameOrAddress, AddressFamily family)
   at Networking.DnsWrapper.GetHostEntry(String hostNameOrAddress)
   at Networking.LocalIpAddressProvider.GetIpAddresses(AddressFamily addressFamily)

@jf-06
Copy link
Contributor Author

jf-06 commented Jun 17, 2024

Redeploying this with debug logging to determine the root cause of the behaviour

@jf-06
Copy link
Contributor Author

jf-06 commented Jun 17, 2024

Problem 1 with Consul averted, it was due to a simple mismatch with the service name on Nomad

@jf-06
Bump Networking to 1.0.5
c17d655 
Fixes one of the issues noted in #316
@jf-06
Copy link
Contributor Author

jf-06 commented Jun 17, 2024

Okay, fixed, LGTM

@jf-06 jf-06 merged commit f2e9068 into master Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
GRIDBOT
Status: Complete
Milestone
SEC-10-WLCC
Development

Successfully merging this pull request may close these issues.

Proper management of environment
1 participant
@jf-06