Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError when BatchTimeFrame is subtracted a Timeframe from within #8

Open
PakMichael opened this issue Mar 1, 2022 · 1 comment
Open

TypeError when BatchTimeFrame is subtracted a Timeframe from within #8

PakMichael opened this issue Mar 1, 2022 · 1 comment

Comments

@PakMichael
Copy link 

        tf_long = TimeFrame(datetime(2022, 3, 1, 12), datetime(2022, 3, 1, 13))
        tf_a = BatchTimeFrame([tf_long])

        tf_sub_a = TimeFrame(datetime(2022, 3, 1, 12, 30), datetime(2022, 3, 1, 12, 45))
        tf_b = BatchTimeFrame([tf_sub_a])

        print(tf_a - tf_b)  #TypeError: Every iterable element should be a BaseTimeFrame
meysam81 added a commit that referenced this issue Nov 5, 2022
@meysam81
drop support for subtracting two batches
b166df3 
meant to fix #8 but ended up thinking that it's illogical to subtract two batches
@meysam81 meysam81 reopened this Nov 5, 2022
@meysam81
Copy link
Owner

meysam81 commented Nov 5, 2022

Hey @PakMichael ,
Thanks for your interest, and sorry for the very long silence. I just saw this a couple of weeks ago.

This issue is quite tricky to address. If you have a good idea for tackling this, please open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PakMichael @meysam81