Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install isc-dhcp-server after rendering configs #359

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

iljarotar
Copy link
Contributor

Closes #357

@iljarotar iljarotar requested a review from a team as a code owner November 21, 2024 14:47
@robertvolkmann
Copy link
Contributor

robertvolkmann commented Nov 22, 2024

Do you understand why we don't notify a handler to restart isc-dhcp-server when its configuration is changed?

tasks:
- name: render dhcpd conf
  template:
    src: dhcpd.conf.j2
    dest: /etc/dhcp/dhcpd.conf
  notify: Restart isc-dhcp-server
  - …

handlers:
  - name: Restart isc-dhcp-server
    service:
      name: "{{ dhcp_service_name }}"
      state: restarted

I also miss a daemon-reload: true.

@iljarotar iljarotar requested a review from Gerrit91 December 4, 2024 15:09
@iljarotar iljarotar self-assigned this Dec 9, 2024
@iljarotar iljarotar merged commit 2176e00 into master Dec 9, 2024
1 check passed
@iljarotar iljarotar deleted the fix-dhcp-tasks-order branch December 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix order of dhcp tasks
3 participants