feat(monitoring): allow disabling prometheus operator #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vknabel
force-pushed
the
allow-disabling-prometheus-operator
branch
from
b5960ca to
b25724d
Compare
|
Info: currently untested |
simcod
reviewed
Oct 16, 2024
simcod
reviewed
Oct 16, 2024
vknabel
force-pushed
the
allow-disabling-prometheus-operator
branch
from
f7ddf5a to
ce0c26a
Compare
In some cases CRDs and the prometheus operator will already be installed by Gardener itself leading to two conflicting instances of the operator. These changes allow disabling deploying the prometheus ooperator to solve this conflict.
vknabel
force-pushed
the
allow-disabling-prometheus-operator
branch
from
60a0e54 to
caad114
Compare
|
@vknabel, are you planning to upgrade the kube-prometheus helm chart to at least version 59.1.0 to ensure compatibility with prometheus-operator v0.74.0, which is deployed by Gardener 1.99? |
|
A dependency upgrade of the kube-prometheus helm chart should be done in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description
In some cases CRDs and the prometheus operator will already be installed by Gardener itself leading to two conflicting instances of the operator. These changes allow disabling deploying the prometheus ooperator to solve this conflict.
Release Notes
monitoring_prometheus_operator_crds_enabledandmonitoring_prometheus_operator_enabledto be able to prevent conflicts with the Gardener Prometheus Operator. Defaults to true to retain the old behavior.