Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant Tool Collab: Allo Protocol #278

Open
Rashmi-278 opened this issue Dec 10, 2024 · 3 comments
Open

Grant Tool Collab: Allo Protocol #278

Rashmi-278 opened this issue Dec 10, 2024 · 3 comments
Assignees
Labels
priority: high High priority

Comments

@Rashmi-278
Copy link
Member

No description provided.

Copy link

linear bot commented Dec 10, 2024

@Rashmi-278 Rashmi-278 added the priority: high High priority label Dec 10, 2024
@Rashmi-278
Copy link
Member Author

Henry from Gitcoin Mentioned that Allo 2.1 is still in Audit Stage

@Rashmi-278 Rashmi-278 self-assigned this Jan 21, 2025
@Rashmi-278
Copy link
Member Author

From thelostone-mc | gitcoin

Hey @rashmivabbigeri !
So henry gave us the TLDR:

  • He's done a mapping of the fields we use and what's the proposed metadata standard
  • A few details aren't stored in our metadata schema like start and end dates as we store them on-chain. We had intentionally done this as we've got on-chain logic which would require this data.
  • Additionally few of these params would updated by the person managing the round. Earlier on we did an exercise and realised it didn't make sense to store the same information in the metadata and on-chain if it's something which would likely be updated (else we'd have to update the metadata any time we change the on-chain variable)
  • This means we won't be able to update our schema to exactly match the standard set by metagov

BUT

When allo stores an metadata, it uses something called a Metadata struct
https://github.com/allo-protocol/allo-v2/blob/main/contracts/core/libraries/Metadata.sol
Which has

  • protocol: an integer (1 == gitcoin's metadata structure )
  • pointer : usually the IPFS hash where the data is stored

@MasterHW proposed reserving protocol 2 for the metagov standard and this would enable gitcoin to support both formats
This also means that as more folks adopt the standard -> they would be able to port / sync their data onto allo.
I think this is a solid way to showing that Gitcoin also supports standard set by DAOIP5 and ensures the gitcoin dapps continue to work as expected with. both structures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority
Projects
None yet
Development

No branches or pull requests

1 participant