Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add tests for GraphBin #2

Closed
3 tasks done
Vini2 opened this issue Aug 12, 2024 · 2 comments
Closed
3 tasks done

TST: add tests for GraphBin #2

Vini2 opened this issue Aug 12, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Vini2
Copy link
Collaborator

Vini2 commented Aug 12, 2024

Add tests for GraphBin in gbintk.

  • test spades input
  • test megahit input
  • test flye input

GraphBin on spades

File name: test_cli_graphbin.py
Function name: test_graphbin_spades_run

Inputs: file names in the tests/data/5G_metaSPAdes directory.

  • graph: assembly_graph_with_scaffolds.gfa
  • contigs: contigs.fasta
  • paths: contigs.paths
  • binned: initial_contig_bins.csv
  • outpath: tmp_dir

How to invoke:

gbintk graphbin --assembler spades --graph {graph} --contigs {contigs} --paths {paths} --binned {binned} --output {outpath}

GraphBin on megahit

File name: test_cli_graphbin.py
Function name: test_graphbin_megahit_run

Inputs: file names in the tests/data/5G_MEGAHIT directory.

  • graph: final.gfa
  • contigs: final.contigs.fa
  • binned: initial_contig_bins.csv
  • outpath: tmp_dir

How to invoke:

gbintk graphbin --assembler megahit --graph {graph} --contigs {contigs} --binned {binned} --output {outpath}

GraphBin on flye

File name: test_cli_graphbin.py
Function name: test_graphbin_flye_run

Inputs: file names in the tests/data/1Y3B_Flye directory.

  • graph: assembly_graph.gfa
  • contigs: assembly.fasta
  • paths: assembly_info.txt
  • binned: initial_contig_bins.csv
  • outpath: tmp_dir

How to invoke:

gbintk graphbin --assembler flye --graph {graph} --contigs {contigs} --paths {paths} --binned {binned} --output {outpath}
@Vini2 Vini2 changed the title TST: add tests for GraphBjn2 TST: add tests for GraphBin2 Aug 13, 2024
@Vini2 Vini2 added the good first issue Good for newcomers label Aug 13, 2024
@Vini2 Vini2 changed the title TST: add tests for GraphBin2 TST: add tests for GraphBin Aug 13, 2024
@KatherineCaley
Copy link
Contributor

Hi @Vini2, happy to take on this issue!

Should the tests inspect the output written to the tmp dir for correctness, or just check that the command is run without failure?

@Vini2
Copy link
Collaborator Author

Vini2 commented Aug 31, 2024

Hi @KatherineCaley!

Thanks for picking this issue. For now just checking that the command runs is enough. I've only checked the output for one case in MetaCoAG only.

Thanks!

@Vini2 Vini2 closed this as completed in cc3d872 Sep 1, 2024
Vini2 added a commit that referenced this issue Sep 1, 2024
TST: add tests for graphbin, fixes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants