Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Benchmark CI to use another repo #464

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

ahmedihabb2
Copy link
Contributor

Description

Now benchmark CI pushes the results to another repo to keep track of benchmark history and to keep the main repo clean

Changelog

  • Download the previous benchmark results removed as we do not need cache anymore as we compare with previous results from the other repo

  • Output directory changed as when it was /bench/matrix.os, the benchmark action will search for previous results in /bench directory, although we store them directly on the repo using matrix.os in order to access them using metacall.github.io/benchmarks/ubuntu-latest not metacall.github.io/benchmarks/bench/ubuntu-latest

  • Add github-token to allow the action pull the specified repo

  • Remove skip-fetch-gh-pages to allow the action fetching the specified repo and compare with the previous results

  • You will need to replace any occurrence of ahmedihabb2/benchmarks with the Metacall benchmarks repo that we will store benchmarks results in it.

Create Private Access token

  • Click on your profile pic in the top right corner
  • Choose settings
  • Scroll down and choose developer settings from the right menu
  • Choose Personal access token and click on Tokens (Classic)
  • Click on Generate new token
  • Specify expiration and select the repo option and this will give the token read and write access to repos
    image
  • Copy the token then go to the repo setting and create a secret called PUSH_TOKEN and put the copied token as a value for the secret
  • Now everything should work fine

@viferga viferga merged commit 0065879 into metacall:develop Jan 31, 2024
17 of 22 checks passed
@viferga
Copy link
Member

viferga commented Feb 1, 2024

@ahmedihabb2 it works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants