MBS-12839: Allow searching for edits by kind of edit type #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mwiencek
reviewed
Nov 30, 2023
reosarevok
force-pushed
the
MBS-12839
branch
3 times, most recently
from
591d412
to
a36c51d
Compare
|
Shouldn't we be determining the edit types on the server, so that if we extend which types of edits are included in a "kind," then any link to a search for that kind will include the new types in the future? Edit: Perhaps extend |
reosarevok
force-pushed
the
MBS-12839
branch
2 times, most recently
from
ce5ca36
to
a9d2a91
Compare
We want to use this as an edit search option, but for that the options should really be translatable.
Rather than having to select all add / merge / whatnot edits one by one by type, this allows us to search for all types of merges or whatnot in one quick click. This will also eventually help us to split the lumped historic relationships that all share the same edit name, since instead of needing to use a grouped "Edit release" name, we will be able to select "kind is edit, entity type is release".
reosarevok
force-pushed
the
MBS-12839
branch
from
a9d2a91
to
15dfac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12839
Problem
Right now, if you want to select all merge edits (for example) in an edit search, you need to select the types one by one, which is a pain in the ass, especially with the multiselect UI.
A secondary issue that is not yet solved by this, but probably needs this as part of a solution: it's not currently possible to search for many specific historic edit types because they have been lumped (based on name) with, say, "Edit release". Ideally, we would have a way to search for edits that do an edit action to a release entity (mostly the current "Edit release" lump) and for every edit type, historic or not, separately.
Solution
This adds a new edit search option, "Edit kind", using the edit kinds already set on edit packages. As such, the edits are split into five options:
add,edit,merge,otherandremove. I made them translatable (with an'edit kind'context) since they will now be user-facing.Testing
Ran a bunch of searches for open edits of all different edit kinds. Did not check that I agree all the currently set kinds make sense, FWIW - I'm just trusting them at the moment.
Actions