MBS-12792: Hide ratings by spammer users #2786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brainzbot, retest this please |
1 similar comment
|
@brainzbot, retest this please |
To deal better with spammer tags and ratings will need a schema change (MBS-12794), but for now we can at least hide links to spammer profiles from the ratings page and make it clear to users that the ratings might be dodgy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12792
Problem
While we block seeing the profiles of spammer users, their ratings are still visible. For cases where the user was specifically spamming ratings, this makes marking them as spammers kinda useless.
We also use the spammer ratings in the calculation of the average community rating, which is not ideal.
Solution
Sadly, it turns out we will need a schema change (MBS-12794) to stop using spammer ratings (and tags) when calculating community results.
For now, this at least hides links to spammer profiles from the ratings page and makes it clear to users viewing from that page that the ratings might be dodgy. There's no indication of that on the sidebar, sadly, but it's something, and it probably doesn't make sense to write code to check for spammer ratings on all pages with sidebars if we plan to stop using them in calculations later on anyway.
Testing
Tested manually. To test, you can use
/artist/9a694506-85b4-4610-ae05-f20934b9aabc/ratings- to test with "legit" ratings too, when using pink, just temporarily add your own rating from mb.org.I didn't add a more formal test since this is meant as a temporary hack.