Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

particleSystem #388

Closed
wants to merge 29 commits into from
Closed

particleSystem #388

wants to merge 29 commits into from

Conversation

OVOAOVO
Copy link
Contributor

@OVOAOVO OVOAOVO commented Sep 14, 2023 •
edited
Loading

particleSystem Origin Version

@OVOAOVO OVOAOVO changed the title particleSystem and nodeTest particleSystem Sep 14, 2023
T-rvw
T-rvw reviewed Sep 14, 2023
View reviewed changes
Engine/Source/Runtime/Rendering/ParticleRenderer.cpp Outdated
Comment on lines 29 to 30
engine::ParticleSystem particles;
particles.Init();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is Render update, not a suitable place to init.

T-rvw
T-rvw requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@T-rvw T-rvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Consider memory allocation : Where to init particle system and How about adjust max particle count?
  2. No function regression compared to bgfx example version : change particle geometry for example.

@OVOAOVO OVOAOVO requested review from roeas and T-rvw September 15, 2023 02:20
@T-rvw T-rvw added the WIP Work In Progress label Sep 15, 2023
@T-rvw T-rvw force-pushed the main branch 2 times, most recently from feb0da8 to fd37097 Compare September 18, 2023 17:56
@OVOAOVO OVOAOVO closed this Nov 3, 2023
@OVOAOVO OVOAOVO deleted the particle_and_nodeTest branch November 3, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeas roeas Awaiting requested review from roeas

@T-rvw T-rvw Awaiting requested review from T-rvw

Assignees
No one assigned
Labels
WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OVOAOVO @T-rvw