Define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING to suppress warn…

…ing C4996 (#433) micro _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING
meta4d-me · Dec 5, 2023 · a7059dd · a7059dd
1 parent 46417aa
commit a7059dd
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/Engine/Auto/Scripts/editor.lua b/Engine/Auto/Scripts/editor.lua
@@ -62,7 +62,8 @@ project("Editor")
 
 	if ENABLE_SPDLOG then
 		defines {
-			"SPDLOG_ENABLE", "SPDLOG_NO_EXCEPTIONS", "FMT_USE_NONTYPE_TEMPLATE_ARGS=0",
+			-- TODO : Remove _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING after spdlog updates the format to the right version.
+			"SPDLOG_ENABLE", "SPDLOG_NO_EXCEPTIONS", "FMT_USE_NONTYPE_TEMPLATE_ARGS=0", "_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING",
 		}
 
 		includedirs {

diff --git a/Engine/Auto/Scripts/engine.lua b/Engine/Auto/Scripts/engine.lua
@@ -108,7 +108,8 @@ project("Engine")
 		}
 
 		defines {
-			"SPDLOG_ENABLE", "SPDLOG_NO_EXCEPTIONS", "FMT_USE_NONTYPE_TEMPLATE_ARGS=0",
+			-- TODO : Remove _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING after spdlog updates the format to the right version.
+			"SPDLOG_ENABLE", "SPDLOG_NO_EXCEPTIONS", "FMT_USE_NONTYPE_TEMPLATE_ARGS=0", "_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING",
 		}
 	end
 

diff --git a/Engine/Source/Runtime/Log/Log.cpp b/Engine/Source/Runtime/Log/Log.cpp
@@ -2,9 +2,9 @@
 
 #ifdef SPDLOG_ENABLE
 
-#include "spdlog/sinks/basic_file_sink.h"
-#include "spdlog/sinks/ostream_sink.h"
-#include "spdlog/sinks/stdout_color_sinks.h"
+#include <spdlog/sinks/basic_file_sink.h>
+#include <spdlog/sinks/ostream_sink.h>
+#include <spdlog/sinks/stdout_color_sinks.h>
 
 namespace engine
 {

diff --git a/Engine/Source/Runtime/Log/Log.h b/Engine/Source/Runtime/Log/Log.h
@@ -7,7 +7,6 @@
 #include <spdlog/spdlog.h>
 #include <spdlog/fmt/ostr.h>
 
-// #include <format>
 #include <sstream>
 
 namespace engine