Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation github action #307

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix documentation github action #307

merged 2 commits into from
Jan 30, 2025

Conversation

mogres
Copy link
Collaborator

@mogres mogres commented Jan 27, 2025

Problem

The github action for documentation fails due to missing pkg_resources package.

Solution

Add setuptools to requirements. (Note, this is a workaround and pkg_resources is deprecated in python 3.12)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  1. Merge PR into main branch
  2. Github action for documentations should run automatically

@mogres mogres requested review from meganrm and rugeli January 27, 2025 19:22
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

Copy link
Collaborator

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me, but I'm curious why the images failed to upload in the packing report for this pr.

@mogres
Copy link
Collaborator Author

mogres commented Jan 30, 2025

The changes look reasonable to me, but I'm curious why the images failed to upload in the packing report for this pr.

@rugeli I am able to see the images on the web browser. Are they still not visible on your end?

@rugeli
Copy link
Collaborator

rugeli commented Jan 30, 2025

The changes look reasonable to me, but I'm curious why the images failed to upload in the packing report for this pr.

@rugeli I am able to see the images on the web browser. Are they still not visible on your end?

They are loaded now! It was likely an error on my end then. Thanks!

@mogres mogres merged commit c93f72d into main Jan 30, 2025
7 checks passed
@mogres mogres deleted the fix/docs-gh-action branch January 30, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants