haiku: fix devel lib install path #14209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haiku have separate install paths for libraries used by runtime loader and compiler. Runtime loader library search path is `$prefix/lib`. Compiler search path (for `ld -lXXX` argumets) is `$prefix/develop/lib`.
dcbaker
reviewed
Jan 30, 2025
eli-schwartz
requested changes
Jan 30, 2025
| @@ -913,6 +913,9 @@ def get_build_dir(self) -> str: | |||
|
|
|||
| def get_import_lib_dir(self) -> str: | |||
| "Install dir for the import library (library used for linking)" | |||
| m = self.machines.host | |||
| if m.is_haiku(): | |||
| return 'develop/lib' | |||
There was a problem hiding this comment.
On windows we know that we can just use the bindir for certain types of file, which is part of the user configuration too.
For Haiku, this is hardcoding a location that only seems to make sense if you know the default libdir hasn't been modified. It's totally opaque to GNU Directory Variables etc. This seems very confusing.
There was a problem hiding this comment.
Should developLibDir option be introduced or what is preferred solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haiku have separate install paths for libraries used by runtime loader and compiler. Runtime loader library search path is
$prefix/lib. Compiler search path (forld -lXXXargumets) is$prefix/develop/lib.