Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevContainers: Include meshtasticd dependencies #5699

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

rickmark
Copy link
Contributor

This includes changes that support two docker dev container issues:

  • Support for floating PlatformIO (locking is causing issues with rebuild) to latest
  • Inclusion of additional dependencies in the the devcontiner for building native / meshtasticd
    ** libusb
    ** libi2c

@caveman99 caveman99 force-pushed the meshtasticd_container branch from 63c7102 to 64a4671 Compare January 5, 2025 10:24
@vidplace7 vidplace7 force-pushed the meshtasticd_container branch from fe2710f to 136d441 Compare January 12, 2025 21:39
@vidplace7 vidplace7 requested a review from caveman99 January 12, 2025 21:45
@vidplace7 vidplace7 changed the title Include meshtasticd dependencies DevContainers: Include meshtasticd dependencies Jan 12, 2025
Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine

@fifieldt fifieldt force-pushed the meshtasticd_container branch from 136d441 to c572292 Compare January 26, 2025 10:59
@vidplace7 vidplace7 force-pushed the meshtasticd_container branch 2 times, most recently from 597e38a to e13113a Compare February 20, 2025 00:22
@fifieldt
Copy link
Contributor

Trunk complained thus:

devcontainer/Dockerfile:34:1
 34:1  medium  Pin versions in pip. Instead of `pip install <package>` use `pip install                  hadolint/DL3013
               <package>==<version>` or `pip install --requirement <requirements file>`                                 

@vidplace7 vidplace7 force-pushed the meshtasticd_container branch from e13113a to 9431a75 Compare February 27, 2025 01:46
@fifieldt fifieldt merged commit 1c827f5 into meshtastic:master Feb 27, 2025
51 checks passed
r41d pushed a commit to r41d/meshtastic-firmware that referenced this pull request Mar 12, 2025
* Include meshtasticd dependencies

* Remove device-ui checkin

* Add trunk rules matching other Dockerfiles

---------

Co-authored-by: vidplace7 <vidplace7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants