Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Use Draft PR and use "Insert a suggestion" when reviewing/responding #115

Closed
lwjohnst86 opened this issue Jun 11, 2019 · 1 comment · Fixed by #118
Closed
Labels
discussion discussion before a proposal

Comments

@lwjohnst86
Copy link
Member

Use Draft Pull Requests to reduce mass emails from GitHub. It also reduces CI usage, since Travis won't run on them.

When reviewing, please use the "Insert a suggestion" if suggesting changes to the actual text. When responding, please accept those changes as they insert the suggestion directly as a commit, thus giving attribution to the reviewer. This reduces work for the PR submitter and gives attribution to the reviewer. Note: This does not work for multi-line suggestions edits (though you can add more lines in the suggestion if desired).

@lwjohnst86 lwjohnst86 added the discussion discussion before a proposal label Jun 11, 2019
@lwjohnst86
Copy link
Member Author

Passed in 2019-06-11 meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion discussion before a proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant