Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoOpReducer for the convenience of having no state change reducer #24

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

KeithYokoma
Copy link
Contributor

NoOpReducer always returns the same state, convenient to have no operation for the state.

@KeithYokoma
Copy link
Contributor Author

Related to #6

@KeithYokoma KeithYokoma self-assigned this Feb 5, 2020
@KeithYokoma KeithYokoma requested a review from yhanada February 5, 2020 05:28
@KeithYokoma KeithYokoma added the enhancement New feature or request label Feb 5, 2020
@yhanada
Copy link
Contributor

yhanada commented Feb 5, 2020

[Q] I'm not sure about the need for this class, in what case do we need it?

Copy link
Contributor

@yhanada yhanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thank you.

@yhanada yhanada merged commit f653266 into master Feb 5, 2020
@yhanada yhanada deleted the keithyokoma/feature/no_op_reducer branch February 5, 2020 07:21
@kittinunf
Copy link
Contributor

kittinunf commented Feb 10, 2020

It might be nice to add some comments to let the user know that if one uses the NoOpReducer, the states Observable won't be notified though (this is due to the fact that the state didn't change). Only, indistinctState will be notified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants