Merge pull request #31 from vveltri/feature/circleIconsOnMLBusinessDi…

…scountBoxView Feature/circle icons on ml business discount box view
mercadolibre · Oct 31, 2019 · 1e52e06 · 1e52e06
2 parents 69f6435 + c1eeae0
commit 1e52e06
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# v1.4
+🚀 1.4 🚀
+- Modified iconCornerRadius on MLBusinessDiscountSingleItemView to 28 in order to make circle icons. Changed icon contentMode to scaleAspectFill.
+- Adjust the size of the Ring view.
+
 # v1.3
 🚀 1.3 🚀
 - Discount Box component 3 layout. (With title and subtitle, with title and without title/subtitle)

diff --git a/MLBusinessComponents.podspec b/MLBusinessComponents.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name             = "MLBusinessComponents"
-  s.version          = "1.3"
+  s.version          = "1.4"
   s.summary          = "MLBusinessComponents for iOS"
   s.homepage         = "https://www.mercadolibre.com"
   s.license          = { :type => "MIT", :file => "LICENSE" }

diff --git a/Source/Components/Discount/Internal/MLBusinessDiscountSingleItemView.swift b/Source/Components/Discount/Internal/MLBusinessDiscountSingleItemView.swift
@@ -13,7 +13,7 @@ import MLUI
 final class MLBusinessDiscountSingleItemView: UIView {
     static let itemHeight: CGFloat = 104
     static let iconImageSize: CGFloat = 56
-    private let iconCornerRadius: CGFloat = 6
+    private let iconCornerRadius: CGFloat = 28
     private let discountSingleItem: MLBusinessSingleItemProtocol
     private var itemIndex: Int = 0
     private var itemSection: Int = 0
@@ -52,7 +52,7 @@ extension MLBusinessDiscountSingleItemView {
         })
 
         self.addSubview(icon)
-        icon.contentMode = .scaleAspectFit
+        icon.contentMode = .scaleAspectFill
         NSLayoutConstraint.activate([
             icon.heightAnchor.constraint(equalToConstant: MLBusinessDiscountSingleItemView.iconImageSize),
             icon.widthAnchor.constraint(equalToConstant: MLBusinessDiscountSingleItemView.iconImageSize),