Fix/use correct min for int48 #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baroooo
requested review from
a team,
chapati23,
denviljclarke and
philbow61
and removed request for
a team and
chapati23
philbow61
approved these changes
Nov 25, 2024
philbow61
reviewed
Nov 25, 2024
baroooo
requested review from
bayological
and removed request for
denviljclarke
bayological
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Sherlock issue 46 by using
type(int48).minOther changes
updates test for withOverflowOnAdd to test the correct limit
Tested
unit tests
Related issues