feat: make Token pausable #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: make Token pausable
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
chapati23
approved these changes
Feb 13, 2024
nvtaveras
approved these changes
Feb 13, 2024
contracts/governance/MentoToken.sol
Outdated
|
|
||
| /** | ||
| * @title Mento Token | ||
| * @author Mento Labs | ||
| * @notice This contract represents the Mento Protocol Token which is a Burnable ERC20 token. | ||
| */ | ||
| contract MentoToken is ERC20Burnable { | ||
| contract MentoToken is Ownable, Pausable, ERC20Burnable { | ||
| /// @notice The address of the emission contract that has the capability to emit new tokens. |
Comment on lines
+74
to
+76
| function unpause() public virtual onlyOwner { | ||
| require(paused(), "MentoToken: token is not paused"); | ||
| _unpause(); |
There was a problem hiding this comment.
couldn't find tests for this function?
nvtaveras
reviewed
Feb 13, 2024
nvtaveras
reviewed
Feb 13, 2024
nvtaveras
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on recent token-related conversations we've decided we want more flexibility when it comes to the time between when we launch governance and give utility to the token, and the time when the token is transferable, i.e. tradable.
Most recent token launches have followed this approach, most notably Safe.
These changes make the token ownable and pausable.
However, even when paused the token can still be transferred by:
Other changes
N/A
Tested
Backwards compatibility
N/A
Documentation
N/A