Track notes by default in Playback

melanchall · Jan 24, 2025 · 7900406 · 7900406
1 parent 88ce4b5
commit 7900406
Show file tree

Hide file tree

Showing 8 changed files with 281 additions and 183 deletions.
diff --git a/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.EventPlayed.cs b/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.EventPlayed.cs
@@ -79,6 +79,7 @@ public void EventPlayed_InterruptNotesOnStop()
                 stopPeriod: stopPeriod,
                 setupPlayback: (context, playback) =>
                 {
+                    playback.TrackNotes = false;
                     playback.InterruptNotesOnStop = true;
                 },
                 afterStart: NoPlaybackAction,
@@ -117,7 +118,7 @@ public void EventPlayed_MoveToStart(double speed)
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveToStart(),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.Zero, "stopped"),
@@ -211,7 +212,7 @@ public void EventPlayed_MoveForward_BeyondDuration()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveForward((MetricTimeSpan)stepAfterStop),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.FromSeconds(4), "stopped"),
@@ -300,7 +301,7 @@ public void EventPlayed_MoveBack_BeyondZero()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveBack((MetricTimeSpan)stepAfterStop),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.Zero, "stopped"),
@@ -338,7 +339,7 @@ public void EventPlayed_MoveToTime()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveToTime(new MetricTimeSpan(0, 0, 1)),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.FromSeconds(1), "stopped"),
@@ -375,7 +376,7 @@ public void EventPlayed_MoveToTime_BeyondDuration()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveToTime(new MetricTimeSpan(0, 0, 10)),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.FromSeconds(4), "stopped"),

diff --git a/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.Metadata.cs b/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.Metadata.cs
@@ -1546,6 +1546,7 @@ public void CheckPlaybackMetadata_NoteCallback_InterruptNotesOnStop()
                 },
                 setupPlayback: playback =>
                 {
+                    playback.TrackNotes = false;
                     playback.InterruptNotesOnStop = true;
                     playback.NoteCallback = NoteCallback;
                 });
@@ -1611,6 +1612,7 @@ public void CheckPlaybackMetadata_NoteCallback_MoveToStart()
                 },
                 setupPlayback: playback =>
                 {
+                    playback.TrackNotes = false;
                     playback.InterruptNotesOnStop = false;
                     playback.NoteCallback = NoteCallback;
                 });
@@ -1722,6 +1724,7 @@ public void CheckPlaybackMetadata_NoteCallback_MoveForward_BeyondDuration()
                 },
                 setupPlayback: playback =>
                 {
+                    playback.TrackNotes = false;
                     playback.InterruptNotesOnStop = false;
                     playback.NoteCallback = NoteCallback;
                 });
@@ -1851,6 +1854,7 @@ public void CheckPlaybackMetadata_NoteCallback_MoveBack_BeyondZero()
                 },
                 setupPlayback: playback =>
                 {
+                    playback.TrackNotes = false;
                     playback.InterruptNotesOnStop = false;
                     playback.NoteCallback = NoteCallback;
                 });
@@ -1947,6 +1951,7 @@ public void CheckPlaybackMetadata_NoteCallback_MoveToTime_BeyondDuration()
                 },
                 setupPlayback: playback =>
                 {
+                    playback.TrackNotes = false;
                     playback.InterruptNotesOnStop = false;
                     playback.NoteCallback = NoteCallback;
                 });

diff --git a/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.Misc.cs b/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.Misc.cs
@@ -732,7 +732,11 @@ public void InterruptNotesOnStop()
                 },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: (context, playback) => playback.InterruptNotesOnStop = true,
+                setupPlayback: (context, playback) =>
+                {
+                    playback.TrackNotes = false;
+                    playback.InterruptNotesOnStop = true;
+                },
                 afterStart: NoPlaybackAction,
                 afterStop: NoPlaybackAction,
                 afterResume: NoPlaybackAction);

diff --git a/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.NoteCallback.cs b/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.NoteCallback.cs
@@ -176,6 +176,7 @@ public void NoteCallback_InterruptNotesOnStop()
                 stopPeriod: stopPeriod,
                 setupPlayback: (context, playback) =>
                 {
+                    playback.TrackNotes = false;
                     playback.InterruptNotesOnStop = true;
                     playback.NoteCallback = NoteCallback;
                 },
@@ -215,7 +216,11 @@ public void NoteCallback_MoveToStart(double speed)
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: (context, playback) => playback.NoteCallback = NoteCallback,
+                setupPlayback: (context, playback) =>
+                {
+                    playback.TrackNotes = false;
+                    playback.NoteCallback = NoteCallback;
+                },
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveToStart(),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.Zero, "stopped"),
@@ -309,7 +314,11 @@ public void NoteCallback_MoveForward_BeyondDuration()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: (context, playback) => playback.NoteCallback = NoteCallback,
+                setupPlayback: (context, playback) =>
+                {
+                    playback.TrackNotes = false;
+                    playback.NoteCallback = NoteCallback;
+                },
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveForward((MetricTimeSpan)stepAfterStop),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.FromSeconds(4), "stopped"),
@@ -398,7 +407,11 @@ public void NoteCallback_MoveBack_BeyondZero()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: (context, playback) => playback.NoteCallback = NoteCallback,
+                setupPlayback: (context, playback) =>
+                {
+                    playback.TrackNotes = false;
+                    playback.NoteCallback = NoteCallback;
+                },
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveBack((MetricTimeSpan)stepAfterStop),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.Zero, "stopped"),
@@ -473,7 +486,11 @@ public void NoteCallback_MoveToTime_BeyondDuration()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: (context, playback) => playback.NoteCallback = NoteCallback,
+                setupPlayback: (context, playback) =>
+                {
+                    playback.TrackNotes = false;
+                    playback.NoteCallback = NoteCallback;
+                },
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveToTime(new MetricTimeSpan(0, 0, 10)),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.FromSeconds(4), "stopped"),

diff --git a/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.Snapping.cs b/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.Snapping.cs
@@ -792,6 +792,8 @@ public void SnapToNotesStarts()
                 stopPeriod: stopPeriod,
                 setupPlayback: (context, playback) =>
                 {
+                    playback.TrackNotes = false;
+
                     snapPointsGroup = playback.Snapping.SnapToNotesStarts();
                     var snapPointsGroup2 = playback.Snapping.SnapToNotesStarts();
                     Assert.That(playback.Snapping.SnapPoints, Has.Count.EqualTo(2), "Count of snap points is invalid.");
@@ -852,6 +854,8 @@ public void SnapToNotesEnds()
                 stopPeriod: stopPeriod,
                 setupPlayback: (context, playback) =>
                 {
+                    playback.TrackNotes = false;
+
                     snapPointsGroup = playback.Snapping.SnapToNotesEnds();
                     var snapPointsGroup2 = playback.Snapping.SnapToNotesEnds();
                     Assert.That(playback.Snapping.SnapPoints, Has.Count.EqualTo(2), "Count of snap points is invalid.");

diff --git a/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.TimeManagement.cs b/DryWetMidi.Tests/Multimedia/Playback/PlaybackTests.TimeManagement.cs
@@ -40,7 +40,7 @@ public void MoveToStart(double speed)
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveToStart(),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.Zero, "stopped"),
@@ -163,7 +163,7 @@ public void MoveForward_BeyondDuration()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveForward((MetricTimeSpan)stepAfterStop),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.FromSeconds(4), "stopped"),
@@ -252,7 +252,7 @@ public void MoveBack_BeyondZero()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveBack((MetricTimeSpan)stepAfterStop),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.Zero, "stopped"),
@@ -327,7 +327,7 @@ public void MoveToTime_BeyondDuration()
                 eventsWillBeSent: new EventToSend[] { },
                 stopAfter: stopAfter,
                 stopPeriod: stopPeriod,
-                setupPlayback: NoPlaybackAction,
+                setupPlayback: (context, playback) => playback.TrackNotes = false,
                 afterStart: NoPlaybackAction,
                 afterStop: (context, playback) => playback.MoveToTime(new MetricTimeSpan(0, 0, 10)),
                 afterResume: (context, playback) => CheckCurrentTime(playback, TimeSpan.FromSeconds(4), "stopped"),