Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential type error in client_agents #899

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix potential type error in client_agents #899

merged 2 commits into from
Jan 3, 2024

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

Fixes #898

What does this PR do?

  • Allows for more than one string to be added to the tuple when sending client_agents.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the bug Something isn't working label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (083d6b9) 100.00% compared to head (806a826) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #899   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          752       752           
=========================================
  Hits           752       752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @sanders41

bors merge

Copy link
Contributor

meili-bors bot commented Jan 3, 2024

@meili-bors meili-bors bot merged commit 10148aa into main Jan 3, 2024
13 checks passed
@meili-bors meili-bors bot deleted the agents-type branch January 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential type error in client_agents
2 participants