added possible Tuple timeout for Config

[structwafel]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a464d39) 100.00% compared to head (3721b49) 100.00%.
Report is 18 commits behind head on main.

❗ Current head 3721b49 differs from pull request most recent head d540bf2. Consider uploading reports for the commit d540bf2 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          752       748    -4     
=========================================
- Hits           752       748    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[curquiza]

Thank you @LGXerxes for your PR

@sanders41 if you have the time to review (never an emergency). Looks too python-oriented for me 😅

[sanders41]

This same change will also need to be made to the timeout in the __init__ of the Client class. Additionally the doc string for the Client class should be updated to explain the Tuple options.

There is a test in tests/client/test_client.py called test_client_timeout_set that should be updated to verify all these options work. That test can be parametrized to cover the options:

@pytest.mark.parametrize("timeout", (5, 5.0, (5, 5), (5.0, 5.0)))
def test_client_timeout_set(timeout):
    client = meilisearch.Client(BASE_URL, MASTER_KEY, timeout=timeout)
    response = client.health()
    assert client.config.timeout == timeout
    assert response["status"] == "available"

[sanders41]

This change looks good. We still need the same change to be made to the timeout in the __init__ of the Client class, and the doc string for the Client class should be updated to explain the Tuple options. Additionally the test update is still needed.

[curquiza]

Closing this for lack of activity. Feel free to re-open of course