Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

Commit

Permalink
Merge #92
Browse files Browse the repository at this point in the history
92: Add PHP 7.2 CI tests r=curquiza a=mmachatschek

This adds PHP 7.2 CI tests.

The `composer.json` tells us, that the version is supported but we do not actually test this.

PS: If we want to upgrade the minimum dependency to `php:^7.3|^8.0` I would gladly do so. PHP 7.2 is not receiving any bugfixes and security fixes anymore and we would encorage the users to upgrade their stack to a supported version.

Co-authored-by: Markus Machatschek <mmachatschek@yahoo.com>
Co-authored-by: Markus Machatschek <mmachatschek@users.noreply.github.com>
  • Loading branch information
3 people authored Feb 3, 2021
2 parents dcd116d + 690ad15 commit 802635d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
tests:
strategy:
matrix:
php-versions: ['7.3', '7.4', '8.0']
php-versions: ['7.2', '7.3', '7.4', '8.0']
name: tests (php ${{ matrix.php-versions }})
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 1 addition & 0 deletions bors.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
status = [
'tests (php 7.2)',
'tests (php 7.3)',
'tests (php 7.4)',
'tests (php 8.0)',
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
"http-interop/http-factory-guzzle": "^1.0"
},
"require-dev": {
"orchestra/testbench": "^5.0 || ^6.0",
"mockery/mockery": "^1.0",
"phpunit/phpunit": "^9.1",
"orchestra/testbench": "^5.0|^6.0",
"mockery/mockery": "^1.3",
"phpunit/phpunit": "^8.5|^9.5",
"friendsofphp/php-cs-fixer": "^2.16",
"guzzlehttp/guzzle": "^7.2"
},
Expand Down

0 comments on commit 802635d

Please sign in to comment.