Rename indexName to indexUid

meilisearch · Feb 26, 2021 · 42dc48d · 42dc48d
1 parent 386874b
commit 42dc48d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 19 deletions.
diff --git a/tests/Feature/MeilisearchConsoleCommandTest.php b/tests/Feature/MeilisearchConsoleCommandTest.php
@@ -18,30 +18,30 @@ public function nameArgumentIsRequired()
     /** @test */
     public function indexCanBeCreatedAndDeleted()
     {
-        $indexName = $this->getPrefixedIndexName('testindex');
+        $indexUid = $this->getPrefixedIndexUid('testindex');
 
         $this->artisan('scout:index', [
-            'name' => $indexName,
+            'name' => $indexUid,
         ])
-            ->expectsOutput('Index "'.$indexName.'" created.')
+            ->expectsOutput('Index "'.$indexUid.'" created.')
             ->assertExitCode(0)
             ->run();
 
-        $indexResponse = resolve(Client::class)->index($indexName)->fetchRawInfo();
+        $indexResponse = resolve(Client::class)->index($indexUid)->fetchRawInfo();
 
         $this->assertIsArray($indexResponse);
-        $this->assertSame($indexName, $indexResponse['uid']);
+        $this->assertSame($indexUid, $indexResponse['uid']);
 
         $this->artisan('scout:index', [
-            'name' => $indexName,
+            'name' => $indexUid,
             '--delete' => true,
         ])
-            ->expectsOutput('Index "'.$indexName.'" deleted.')
+            ->expectsOutput('Index "'.$indexUid.'" deleted.')
             ->assertExitCode(0)
             ->run();
 
         try {
-            resolve(Client::class)->index($indexName)->fetchRawInfo();
+            resolve(Client::class)->index($indexUid)->fetchRawInfo();
             $this->fail('Exception should be thrown that index doesn\'t exist!');
         } catch (HTTPRequestException $exception) {
             $this->assertTrue(true);

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -31,9 +31,9 @@ protected function getEnvironmentSetUp($app)
         config()->set('scout.prefix', $this->getPrefix());
     }
 
-    protected function getPrefixedIndexName(string $indexName)
+    protected function getPrefixedIndexUid(string $indexUid)
     {
-        return sprintf('%s_%s', $this->getPrefix(), $indexName);
+        return sprintf('%s_%s', $this->getPrefix(), $indexUid);
     }
 
     protected function getPrefix()

diff --git a/tests/Unit/MeilisearchConsoleCommandTest.php b/tests/Unit/MeilisearchConsoleCommandTest.php
@@ -16,17 +16,17 @@ class MeilisearchConsoleCommandTest extends TestCase
     public function commandCreatesIndex()
     {
         $client = $this->mock(Client::class);
-        $client->expects('createIndex')->with($indexName = 'testindex', [])->andReturn(m::mock(Indexes::class));
+        $client->expects('createIndex')->with($indexUid = 'testindex', [])->andReturn(m::mock(Indexes::class));
 
         $engineManager = $this->mock(EngineManager::class);
         $engineManager->shouldReceive('engine')->with('meilisearch')->andReturn(new MeilisearchEngine(
             $client
         ));
 
         $this->artisan('scout:index', [
-            'name' => $indexName,
+            'name' => $indexUid,
         ])
-            ->expectsOutput('Index "'.$indexName.'" created.')
+            ->expectsOutput('Index "'.$indexUid.'" created.')
             ->assertExitCode(0)
             ->run();
     }
@@ -37,7 +37,7 @@ public function keyParameterSetsPrimaryKeyOption()
         $client = $this->mock(Client::class);
         $client
             ->expects('createIndex')
-            ->with($indexName = 'testindex', ['primaryKey' => $testPrimaryKey = 'foobar'])
+            ->with($indexUid = 'testindex', ['primaryKey' => $testPrimaryKey = 'foobar'])
             ->andReturn(m::mock(Indexes::class));
 
         $engineManager = $this->mock(EngineManager::class);
@@ -46,10 +46,10 @@ public function keyParameterSetsPrimaryKeyOption()
         ));
 
         $this->artisan('scout:index', [
-            'name' => $indexName,
+            'name' => $indexUid,
             '--key' => $testPrimaryKey,
         ])
-            ->expectsOutput('Index "'.$indexName.'" created.')
+            ->expectsOutput('Index "'.$indexUid.'" created.')
             ->assertExitCode(0)
             ->run();
     }
@@ -58,18 +58,18 @@ public function keyParameterSetsPrimaryKeyOption()
     public function deleteParameterDeletesIndex()
     {
         $client = $this->mock(Client::class);
-        $client->expects('deleteIndex')->with($indexName = 'testindex')->andReturn([]);
+        $client->expects('deleteIndex')->with($indexUid = 'testindex')->andReturn([]);
 
         $engineManager = $this->mock(EngineManager::class);
         $engineManager->shouldReceive('engine')->with('meilisearch')->andReturn(new MeilisearchEngine(
             $client
         ));
 
         $this->artisan('scout:index', [
-            'name' => $indexName,
+            'name' => $indexUid,
             '--delete' => true,
         ])
-            ->expectsOutput('Index "'.$indexName.'" deleted.')
+            ->expectsOutput('Index "'.$indexUid.'" deleted.')
             ->assertExitCode(0)
             ->run();
     }