Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.6] Support proximityPrecision setting #702

Closed
7 tasks
curquiza opened this issue Jan 15, 2024 · 2 comments · Fixed by #710
Closed
7 tasks

[v1.6] Support proximityPrecision setting #702

curquiza opened this issue Jan 15, 2024 · 2 comments · Fixed by #710
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Following this central issue

This is related to a newly introduced feature in Meilisearch v1.6.0: the proximity-precision setting.

Refer to docs for more information.

  • Add the new settings: proximityPrecision with get, update, and reset methods associated.
    Here are the JS equivalents in meilisearch-js you should create for this repository:
client.index('indexName').getProximityPrecision(); // calls GET /indexes/:uid/settings/proximity-precision
client.index('indexName').updateProximityPrecision('byAttribute');  // calls PUT /indexes/:uid/settings/proximity-precision
client.index('indexName').resetProximityPrecision(); // calls DELETE /indexes/:uid/settings/proximity-precision
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Jan 15, 2024
@iMezemz
Copy link
Contributor

iMezemz commented Feb 3, 2024

Hello @curquiza , I would love to get on this issue. Is it still unimplemented?

@curquiza
Copy link
Member Author

curquiza commented Feb 5, 2024

Hello @iMezemz
If i'm correct it's not implemented yet

Thanks for your PR, I will try to take a look this week or next week 👍

@meili-bors meili-bors bot closed this as completed in f7f5337 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants