Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support proximityPrecision setting #564

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Aug 21, 2024

Pull Request

Related issue

Fixes #507

What does this PR do?

  • This PR support proximityPrecision setting

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ja7ad Ja7ad changed the title feat: support proximityPrecision setting Feat support proximityPrecision setting Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (db30204) to head (ab899b2).
Report is 2 commits behind head on main.

Files Patch % Lines
index_settings.go 86.04% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   86.75%   86.73%   -0.02%     
==========================================
  Files          11       11              
  Lines        2000     2043      +43     
==========================================
+ Hits         1735     1772      +37     
- Misses        162      165       +3     
- Partials      103      106       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza added the enhancement New feature or request label Aug 21, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Aug 21, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 1dfc51b into meilisearch:main Aug 21, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.6] Support proximityPrecision setting
2 participants