-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests related to the next Meilisearch release (v1.6.0) #368
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 81.85% 75.83% -6.03%
==========================================
Files 57 55 -2
Lines 1345 1320 -25
==========================================
- Hits 1101 1001 -100
- Misses 244 319 +75 ☔ View full report in Codecov by Sentry. |
d35f65b
to
aaeeef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
368: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#294 This PR: - gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.6.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: curquiza <clementine@meilisearch.com> Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Build failed: |
7a9c1b5
to
7635e66
Compare
@ahmednfwela do you know how to fix this linter issue? 😇 |
@curquiza it appears |
What's weird is that locally there are no errors |
I was running with dart 3.2.3, let's see with 3.2.4 |
I currently have |
I didn't get the deps from tools, now I have the same as you @ahmednfwela no error locally... |
Looking at the errors though, it seems it's restoring an older version of but JWTException was introduced at 2.8.0 (I even commented there at the time for the same reason) seems like we have to update all packages in pubspec.yaml to the latest minor version to fix this |
All green now 👍 |
bors merge |
Build succeeded: |
Related to this issue: meilisearch/integration-guides#294
This PR:
This PR is auto-generated for the pre-release week purpose.