Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read in files from ipopt bin folder #288

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

philsuess
Copy link

Hello,

thank you for this project.

This change is rather small: it does not assume to know the folder contents of the ipopt bin folder, but reads them out. When using this with the latest release from the ipopt github repo, this is what is printed out:

Found ipopt binaries ['coinmumps-3.dll', 'ipopt-3.dll', 'ipoptamplinterface-3.dll', 'libifcoremd.dll', 'libiomp5md.dll', 'libmmd.dll', 'sipopt-3.dll', 'svml_dispmd.dll'].

Let me know if this is helpful.

Best,

Phil

@moorepants
Copy link
Collaborator

This is potentially helpful, but we currently support a range of IPOPT versions, so I needs to work with that range. Have you tested with the older versions?

@philsuess
Copy link
Author

I tested it with the one specified in the setup.py (line 145): https://github.com/coin-or/Ipopt/releases/download/releases%2F3.13.2/Ipopt-3.13.2-win64-msvs2019-md.zip

and the latest one: https://github.com/coin-or/Ipopt/releases/download/releases%2F3.14.17/Ipopt-3.14.17-win64-msvs2022-md.zip

@moorepants
Copy link
Collaborator

The failure seems to be unrelated (something like a corrupt package):

  ld_impl_linux-64-2.43-h712a8e2_2.conda extraction failed
  Warning: error    libmamba Error when extracting package: Error reading from archive: Truncated ZIP file data
  
  error    libmamba Error when extracting package: Error reading from archive: Truncated ZIP file data
  Warning: Found incorrect download: ld_impl_linux-64. Aborting
  
  Found incorrect download: ld_impl_linux-64. Aborting
  Warning: 
  # >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<<
  
      Traceback (most recent call last):
        File "/home/runner/miniconda3/lib/python3.12/site-packages/conda/exception_handler.py", line 18, in __call__
          return func(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/home/runner/miniconda3/lib/python3.12/site-packages/mamba/mamba.py", line 960, in exception_converter
          raise e
        File "/home/runner/miniconda3/lib/python3.12/site-packages/mamba/mamba.py", line 953, in exception_converter
          exit_code = _wrapped_main(*args, **kwargs)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/runner/miniconda3/lib/python3.12/site-packages/mamba/mamba.py", line 899, in _wrapped_main
          result = do_call(parsed_args, p)
                   ^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/runner/miniconda3/lib/python3.12/site-packages/mamba/mamba.py", line 768, in do_call
          exit_code = create(args, parser)
                      ^^^^^^^^^^^^^^^^^^^^
        File "/home/runner/miniconda3/lib/python3.12/site-packages/mamba/mamba.py", line 603, in create
          return install(args, parser, "create")
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/home/runner/miniconda3/lib/python3.12/site-packages/mamba/mamba.py", line 559, in install
          transaction.fetch_extract_packages()
      RuntimeError: Found incorrect download: ld_impl_linux-64. Aborting

@philsuess
Copy link
Author

Mind, when I say that I have tested it, I mean that the pip install . goes through successfully. However, I still can't get over the error

cyipopt\__init__.py:12: in <module>
    from ipopt_wrapper import *
E   ImportError: DLL load failed while importing ipopt_wrapper: The specified module could not be found.

I am sure that this error is unrelated to my changes - I get the same error when I run pytest on this repo (without my changes). That's another problem, however. Just want to state my full disclosure :)

@moorepants
Copy link
Collaborator

moorepants commented Jan 27, 2025

The "Manually install on Windows" CI runs shows:


Run python setup.py install
Using Ipopt adjacent to setup.py in D:\a\cyipopt\cyipopt on Windows.
Found ipopt binaries ['ipopt-3.dll', 'ipoptamplinterface-3.dll', 'libifcoremd.dll', 'libmmd.dll', 'msvcp140.dll', 'svml_dispmd.dll', 'vcruntime140.dll']
running install

And it successfully solves the example problem, so I the change should be suitable.

@moorepants
Copy link
Collaborator

Thanks!

@moorepants moorepants merged commit 097fae9 into mechmotum:master Jan 27, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants