Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully allow Cython 3. #240

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Conversation

moorepants
Copy link
Collaborator

No description provided.

@moorepants
Copy link
Collaborator Author

mac, 3.8, 3.13:

=========================== short test summary info ============================
FAILED cyipopt/tests/unit/test_scipy_ipopt_from_scipy.py::TestSLSQP::test_minimize_unbounded_approximated - AssertionError: b'Algorithm stopped at a point that was converged, not to "desired" tolerances, but to "acceptable" tolerances (see the acceptable-... options).'
====== 1 failed, 90 passed, 12 skipped, 1 xfailed, 19 warnings in 11.74s =======
Error: Process completed with exit code 1.

This was failing on MacOSC in these versions:

Python 3.8 + IPOPT 3.13 & 3.14
Python 3.9 + IPOPT 3.13
Python 3.10 + IPOPT 3.13 & 314

with this error:

________________ TestSLSQP.test_minimize_unbounded_approximated ________________

self = <cyipopt.tests.unit.test_scipy_ipopt_from_scipy.TestSLSQP object at 0x115154a30>

    def test_minimize_unbounded_approximated(self):
        # Minimize, method=None: unbounded, approximated jacobian.
        jacs = [None, False]
        for jac in jacs:
            res = minimize(self.fun, [-1.0, 1.0], args=(-1.0, ),
                           jac=jac, method=None,
                           options=self.opts)
>           assert_(res['success'], res['message'])
E           AssertionError: b'Algorithm stopped at a point that was converged, not to "desired" tolerances, but to "acceptable" tolerances (see the acceptable-... options).'

cyipopt/tests/unit/test_scipy_ipopt_from_scipy.py:158: AssertionError
=========================== short test summary info ============================
FAILED cyipopt/tests/unit/test_scipy_ipopt_from_scipy.py::TestSLSQP::test_minimize_unbounded_approximated - AssertionError: b'Algorithm stopped at a point that was converged, not to "desired" tolerances, but to "acceptable" tolerances (see the acceptable-... options).'
====== 1 failed, 90 passed, 12 skipped, 1 xfailed, 43 warnings in 11.88s =======
Error: Process completed with exit code 1.

I changed the guess for this test to possibly give convergence.
@moorepants moorepants merged commit 146db46 into mechmotum:master Nov 26, 2023
34 checks passed
@moorepants moorepants deleted the allow-cython-3 branch November 26, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant