fix: fixed search #242
Open
fix: fixed search #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoNish
commented
Dec 22, 2022
•
NanoNish
commented
- changed query to autocomplete type
- added a path var for defining the field to search in
- added filter for path var so only certain fields can be filled in
- updated swagger to include path in search docs
- changed query to autocomplete type - added a path var for defining the field to search in - added temp tests for search and checking connection with db - updated swagger to include path in search docs
- added filter for path var
- added IsPathValid to constants.go - removed logic from search.go in controllers
This reverts commit 8934f5d.
- added IsPathValid to constants.go - removed logic from search.go in controllers
|
IMPORTANT: |
renauga
reviewed
Jan 3, 2023
| //Checking for possible fields, default is "username" | ||
| var possible_path []string | ||
| var good_path bool = false | ||
| possible_path = []string{"username", "fullname", "handle.codechef", "handle.codeforces", "handle.hackerearth", "handle.hackerrank", "handle.spoj"} |
There was a problem hiding this comment.
Re-check the list of platforms. Leetcode is missing and hackerearth is extra.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.