Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in CropBuilder where N, P and K quantities must be always specified #17

Open
mcmancini opened this issue Feb 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mcmancini
Copy link
Owner

The current version of the CropBuilder to run WOFOST in bulk (i.e., the class that allows to build the parameter structure to override devault parameters in WOFOST based on user input) at the moment is not flexible enough in the definition of the fertilisation events. Fertilisation events must be defined as timings of NPK fertilisation events, and associated quantities of nutrients for each timing event. The way I intend for this to work is to preload default agromanagement in terms of number of fertilisation events, timing and quantities, and then to override only the values of interest, if any. At the moment, however, the script does not take default values and breaks if some of the timings or quantities are not being defined by the user through the input csv file.
Changes will need to be made for the _generate_args() method in the CropBuilder class, lines 435 and following.

@mcmancini mcmancini added the bug Something isn't working label Feb 1, 2024
@mcmancini mcmancini self-assigned this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant