Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cross-section models #81

Merged
merged 98 commits into from
Dec 20, 2024
Merged

Add cross-section models #81

merged 98 commits into from
Dec 20, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

@dbrakenhoff dbrakenhoff commented Nov 7, 2024 •
edited
Loading

  • add LineSink1DBase, DischargeLineSink1D, LineSink1D and HeadLineSink1D
  • add example notebook with comparison to analytical solutions. Both single and multiple aquifer examples shown.
  • add continuity of head and flow elements/equations
  • add example notebook for 1d inhom elements

EDIT: update 11/11/2024

@dbrakenhoff
Add LineSink1D:
eed3372 
- first linesink1d commit
- add LineSink1DBase, DischargeLineSink1D, LineSink1D and HeadLineSink1D
- add example notebook with comparison to analytical solutions. Only single aquifers for now.
@dbrakenhoff
ruff
96119ac
@mbakker7
Copy link
Owner

mbakker7 commented Nov 7, 2024

Very nice start! There are some errors because timml cannot be imported. Maybe store the timml solution separately or should we add a dependency?

@dbrakenhoff
add timml for linesink1d notebook
c2dcd7f
@dbrakenhoff
add linedoublet1d
1645f33 
- add 1d leaky wall
- add example in notebook
@dbrakenhoff
add linedoublet1d
7ba144d 
- add 1d leaky wall
- add example in notebook
@dbrakenhoff dbrakenhoff changed the title Add Linesink1d Add Linesink1D and LineDoublet1D Nov 8, 2024
dbrakenhoff and others added 23 commits November 8, 2024 11:31
@dbrakenhoff
renamed x coordinate
9ff976e
@dbrakenhoff
Merge remote-tracking branch 'origin/dev' into linesink1d
af372fa
@dbrakenhoff
add multi layer example for 1d linesinks and doublets
d1fe487
@dbrakenhoff
add HeadDiffLineSink1D and FluxDiffLineSink1D
124b061
@dbrakenhoff
add HeadDiffEquation for continuity of head and FluxDiffEquation for …
99a63db 
…continuity of flow
@dbrakenhoff
add tiny
0e73211
@dbrakenhoff
add tiny
6530419
@dbrakenhoff
remove parentheses for leaky layer parameter label on plot
b23c252
@dbrakenhoff
use python conventions for function names
c48f95f
@dbrakenhoff
add tiny
145ad51
@dbrakenhoff
ruff
9517b7e
@dbrakenhoff
add inhom 1d element notebook
633bded
@mbakker7
Added boundary check on leaky wall example
bf90ec1
@dbrakenhoff
Add StripInhom elements
5bf0c49
@dbrakenhoff
add add_inhom to Aquifer class
c6af896
@dbrakenhoff
force overloading of is_inside in AquiferData
5bd7ea9
@dbrakenhoff
add is_inside to Aquifer class
ee58ac3
@dbrakenhoff
for RHS elements compute influence on xc (not xcin/xcout) and specify…
d89c9b1 
… correct aquifer
@dbrakenhoff
add self.aq in LineSink1DBase
47f3831 
to pass correct aquifer for inhom1d linesink elements
@dbrakenhoff
move initialize to ensure inhom elements are initialized prior to pop…
2dc2036 
…ulating model element lists
@dbrakenhoff
add stripareasink element
78a3073
@dbrakenhoff
reurn nb
c8756f8
@dbrakenhoff
add examples
74a7107 
- 3 inhom example
- stripareasink example
dbrakenhoff and others added 22 commits December 18, 2024 18:01
@dbrakenhoff
fix xsection labels
5730d58
@dbrakenhoff
docstrings and add support for ml.plots.xsection() for cross-section …
cc55bb4 
…models
@dbrakenhoff
minor style fixes
06ba45c
@dbrakenhoff
add howto tidal boundary notebook
794826e
@dbrakenhoff
add a simpel watex example, calibrating aquifer parameters for a tida…
29bf5ca 
…l river with two observation wells
@dbrakenhoff
add howtos to docs
5b16771
@mbakker7
Update howto_xsection_model.ipynb
2b3ad15
@mbakker7
Merge branch 'linesink1d' of https://github.com/mbakker7/ttim into li…
7e79c1a 
…nesink1d
@mbakker7
fix from_lay to_lay
ce97262 
but need to fix multi-layer inhoms in calibrate
@mbakker7
fix fit xsection multiple layers
4b0127b
@mbakker7
fit by reference still needs a fix it seems
27e7bae
@mbakker7
specify inhoms by tuple of names in calibrate
e2beb86
@mbakker7
added option x1=-np.inf, x2=+np.inf
eec2a1a
@mbakker7
Rewrote howto tidal notebook
91b1bc6 
Simplified and updated
@mbakker7
removed leftover print statement
2955e39
@mbakker7
fixed sioux notebook
b7ef3ca 
took out well resistance as there is no measurement inside the well
@mbakker7
ruff
a47695b
@mbakker7
last ruff stuff
457fcef
@mbakker7
Added explanations to the xsection howto
74d4ab3
@dbrakenhoff
show warning when using old layer specification method
77bcb44
@dbrakenhoff
minor fixes to text in nb
6eb0428
@dbrakenhoff
minor fixes to text in nb
c982386
@dbrakenhoff dbrakenhoff marked this pull request as ready for review December 19, 2024 22:27
dbrakenhoff
dbrakenhoff commented Dec 19, 2024
View reviewed changes
docs/01howto/index.rst Outdated Show resolved Hide resolved
dbrakenhoff
dbrakenhoff commented Dec 19, 2024
View reviewed changes
ttim/linedoublet1d.py Outdated Show resolved Hide resolved
dbrakenhoff
dbrakenhoff commented Dec 19, 2024
View reviewed changes
ttim/stripareasink.py Outdated Show resolved Hide resolved
@dbrakenhoff dbrakenhoff merged commit 7d5ca53 into dev Dec 20, 2024
6 checks passed
@dbrakenhoff dbrakenhoff deleted the linesink1d branch December 20, 2024 10:03
@dbrakenhoff dbrakenhoff mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrakenhoff @mbakker7