Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for numba bessel functions #77

Merged
merged 5 commits into from
Nov 8, 2024
Merged

add tests for numba bessel functions #77

merged 5 commits into from
Nov 8, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

Add tests and test with JIT disabled to get coverage results.

- add extra CI step to add coverage for numba bessel
- is exactly equal on my pc, but has extra decimal in complex part on gh actions, diff is 5e-17 so that should be okay.
- cannot set array item with array, must be scalar (zminzbar and omega)
- could not unify float/int and complex for term1 and term2
Copy link
Owner

@mbakker7 mbakker7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix and good to add those tests.

@dbrakenhoff dbrakenhoff merged commit b0da425 into dev Nov 8, 2024
6 checks passed
@dbrakenhoff dbrakenhoff deleted the numba_tests branch November 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something wrong with types in 2 numba bessel functions Coverage at 51%
2 participants