Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTim plots #76

Merged
merged 17 commits into from
Nov 7, 2024
Merged

TTim plots #76

merged 17 commits into from
Nov 7, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

No description provided.

- add topview method (the old .plot()
- add xsection()
- add head_along_line(), the old xsection
- move to object oriented plotting using ax instead of plt
- add .plots submodule
- reinstate ml.plot using new module
- deprecate xsection
- somehow search and replace wasnt working in vscode, now using right methods everywhere
- improve legend in head_along_line
- add ax to element plot methods
@dbrakenhoff dbrakenhoff requested a review from mbakker7 November 7, 2024 11:20
@dbrakenhoff dbrakenhoff linked an issue Nov 7, 2024 that may be closed by this pull request
@mbakker7
Copy link
Owner

mbakker7 commented Nov 7, 2024

I fixed a few minor things and prettified some of the notebooks.
Now the checks complain about ruff, but ruff checks out on my Mac just fine.
Seems to be a Windows thingy. Any ideas how to fix that?

@dbrakenhoff
Copy link
Collaborator Author

Seems like ruff was not running on the notebooks?

@mbakker7
Copy link
Owner

mbakker7 commented Nov 7, 2024

Looks like they want double quotes. Not sure why my ruff thought single quotes are fine.

Copy link
Owner

@mbakker7 mbakker7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. Ready to go.

@mbakker7 mbakker7 merged commit f97363c into dev Nov 7, 2024
6 checks passed
@dbrakenhoff dbrakenhoff deleted the ttim_plots branch November 7, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better plots for TTim
2 participants