Fix/ignore fields of unsupported type (#3)

* Does no longer panic on unsupported fields * Updates the changelog
matzefriedrich · Jun 12, 2024 · d5a0938 · d5a0938
1 parent 9bf40da
commit d5a0938
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,11 +8,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 
-## [0.2.4] - cobra-extensions v0.2.4, 2024-06-12
+## [0.2.5] - cobra-extensions v0.2.5, 2024-06-12
 
 ### Fixes
 
-- The `reflection` module panicked when reflecting fields with an interface type.
+- The `reflection` module ignores fields of unsupported types
 
 
 ## [0.2.3] - cobra-extensions v0.2.3, 2024-04-25

diff --git a/pkg/reflection/reflection.go b/pkg/reflection/reflection.go
@@ -111,8 +111,6 @@ func tryReflectArgumentsDescriptor(m ReflectedObject, target ArgumentsDescriptor
 					hasCommandArgs = true
 				}
 			}
-		default:
-			panic("unhandled default case")
 		}
 	})
 

diff --git a/pkg/typed_command_test.go b/pkg/typed_command_test.go
@@ -34,7 +34,8 @@ func Test_CreateTypedCommand(t *testing.T) {
 }
 
 type logger struct {
-	w io.Writer
+	w                    io.Writer
+	unsupportedFieldType int8
 }
 
 type testCommand2 struct {
-Original file line number
+Diff line change
@@ Expand Up @@
     					hasCommandArgs = true
     				}
     			}
-    		default:
-    			panic("unhandled default case")
     		}
     	})
@@ Expand Down @@