Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walk: opts.onFile is not inclided in promissory chain #3

Open
matutter opened this issue Oct 24, 2016 · 1 comment
Open

walk: opts.onFile is not inclided in promissory chain #3

matutter opened this issue Oct 24, 2016 · 1 comment

Comments

@matutter
Copy link
Owner

The onfile callback, if it returns a promise, doesn't get included in the promissory chain and isn't cat by the exception handler for profs.walk.

@matutter
Copy link
Owner Author

Supposedly this code doesn't work

var opts = {
  onFile = file => new Promise(resolve =>{
    setTimeout(() => resolve(first = true), 3000)
  }) 
}

profs.walk('.', opts).then( () => assert(first, 'walk.onFile callback still going') )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant