Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not play nice with adapters #32

Open
kevinludwig opened this issue May 18, 2017 · 0 comments
Open

Does not play nice with adapters #32

kevinludwig opened this issue May 18, 2017 · 0 comments

Comments

@kevinludwig
Copy link

in your broadcast method, you're simply doing a forEach over every socket and emitting directly to the socket. I think when you do that you're not allowing for the fact that there may be multiple nodes (and thus sockets that should be broadcast to that are not in the same process or on the same machine).

I think you can fix this by doing io.sockets.emit(...) to emit to all sockets and not just the in-process ones.

Note: I haven't tried this yet but its the impression I get when I read the code; and I'm unable to get multi-instance working with socket.io-redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant