Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-62094] E2E: Don't including loading screen or other windows in server map, remove check for loading screen finish #3252

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[MM-62094] E2E: Don't including loading screen or other windows in server map, remove check for loading screen finish #3252

wants to merge 6 commits into from

Conversation

devinbinnie
Copy link
Member

Summary

Ticket Link

Checklist

Device Information

This PR was tested on:

Screenshots

Release Note

@devinbinnie devinbinnie added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 12, 2024
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit e7fed2f

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar

Test Summary for macOS on commit e7fed2f

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • copylink MM-T125 Copy Link can be used from channel LHS
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • Trigger Notification From desktop should receive a notification on macOS
  • LongServerName MM-T4050 Long server name

Test Summary for Windows on commit e7fed2f

New failed tests found on Windows:

  • focus Focus textbox tests MM-T1315 should return focus to the message box when closing the settings window

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 12, 2024
@devinbinnie devinbinnie added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 13, 2024
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit 9fdd96e

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar

Test Summary for macOS on commit 9fdd96e

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • Trigger Notification From desktop should receive a notification on macOS
  • popup MM-T2827_2 should be able to cut and paste in popup windows
  • popup MM-T2827_3 should be able to copy and paste in popup windows

Test Summary for Windows on commit 9fdd96e

New failed tests found on Windows:

  • focus Focus textbox tests MM-T1315 should return focus to the message box when closing the settings window

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 13, 2024
@devinbinnie devinbinnie added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 13, 2024
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit ad4b160

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_1 Zoom in when CmdOrCtrl+Plus is pressed
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed
  • RemoveServerModal MM-T4390_3 should disappear on click Close

Test Summary for macOS on commit ad4b160

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • Trigger Notification From desktop should receive a notification on macOS
  • popup MM-T2827_2 should be able to cut and paste in popup windows
  • popup MM-T2827_3 should be able to copy and paste in popup windows

Test Summary for Windows on commit ad4b160

New failed tests found on Windows:

  • focus Focus textbox tests MM-T1315 should return focus to the message box when closing the settings window
  • menu/view MM-T817 Actual Size Zoom in the menu bar

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 13, 2024
@devinbinnie devinbinnie added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 13, 2024
@devinbinnie devinbinnie added Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests and removed Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests labels Dec 13, 2024
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit 1d2f65e

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar

Test Summary for macOS on commit 1d2f65e

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • copylink MM-T125 Copy Link can be used from channel LHS
  • Trigger Notification From desktop should receive a notification on macOS

Test Summary for Windows on commit 1d2f65e

New failed tests found on Windows:

  • focus Focus textbox tests MM-T1315 should return focus to the message box when closing the settings window

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Dec 13, 2024
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit 67c8995

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed

Test Summary for macOS on commit 67c8995

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed
  • Trigger Notification From desktop should receive a notification on macOS
  • popup MM-T2827_2 should be able to cut and paste in popup windows
  • popup MM-T2827_3 should be able to copy and paste in popup windows

Test Summary for Windows on commit 67c8995

New failed tests found on Windows:

  • focus Focus textbox tests MM-T1315 should return focus to the message box when closing the settings window

@yasserfaraazkhan
Copy link
Contributor

/update-branch

@devinbinnie
Copy link
Member Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan self-requested a review January 9, 2025 09:48
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jan 16, 2025
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit 945c1bf

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar
  • menu/view MM-T813 Control+F should focus the search bar in Mattermost
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_1 Zoom in when CmdOrCtrl+Plus is pressed
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_1 Zoom out when CmdOrCtrl+Minus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed

Test Summary for macOS on commit 945c1bf

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • copylink MM-T125 Copy Link can be used from channel LHS
  • menu/view MM-T813 Control+F should focus the search bar in Mattermost
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_1 Zoom in when CmdOrCtrl+Plus is pressed
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_1 Zoom out when CmdOrCtrl+Minus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed
  • Trigger Notification From desktop should receive a notification on macOS

Test Summary for Windows on commit 945c1bf

New failed tests found on Windows:

  • focus Focus textbox tests MM-T1315 should return focus to the message box when closing the settings window
  • menu/view MM-T813 Control+F should focus the search bar in Mattermost
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_1 Zoom in when CmdOrCtrl+Plus is pressed
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_1 Zoom out when CmdOrCtrl+Minus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jan 16, 2025
@yasserfaraazkhan yasserfaraazkhan self-assigned this Jan 19, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jan 19, 2025
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit 8f4b64d

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed

Test Summary for macOS on commit 8f4b64d

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • copylink MM-T125 Copy Link can be used from channel LHS
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • Trigger Notification From desktop should receive a notification on macOS
  • popup MM-T2827_2 should be able to cut and paste in popup windows
  • popup MM-T2827_3 should be able to copy and paste in popup windows
  • Add Server Modal MM-T1312 should focus the first text input
  • EditServerModal MM-T2826_3 should not edit server if an invalid server address has been set
  • config MM-T4402 should upgrade v0 config file
  • window MM-T4403_1 should restore window bounds
  • window MM-T4403_2 should NOT restore window bounds if x is located on outside of viewarea
  • window MM-T4403_3 should NOT restore window bounds if y is located on outside of viewarea

Test Summary for Windows on commit 8f4b64d

All stable tests passed on Windows.

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jan 19, 2025
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jan 19, 2025
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit 8f4b64d

New failed tests found on Linux:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed

Test Summary for macOS on commit 8f4b64d

New failed tests found on macOS:

  • downloads/downloads_manager MM-22239 should open downloads dropdown when a download starts
  • edit_menu MM-T807 Undo in the Menu Bar
  • edit_menu MM-T808 Redo in the Menu Bar
  • edit_menu MM-T809 Cut in the Menu Bar
  • edit_menu MM-T810 Copy in the Menu Bar
  • edit_menu MM-T812 Select All in the Menu Bar
  • Trigger Notification From desktop should receive a notification on macOS
  • popup MM-T2827_2 should be able to cut and paste in popup windows
  • popup MM-T2827_3 should be able to copy and paste in popup windows

Test Summary for Windows on commit 8f4b64d

New failed tests found on Windows:

  • focus Focus textbox tests MM-T1315 should return focus to the message box when closing the settings window

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan Awaiting requested review from yasserfaraazkhan

At least 2 approving reviews are required to merge this pull request.

Assignees

@yasserfaraazkhan yasserfaraazkhan

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devinbinnie @yasserfaraazkhan @mm-cloud-bot @mattermost-build